Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ligatures flag for Recursive font #60

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Fix ligatures flag for Recursive font #60

merged 1 commit into from
Nov 20, 2020

Conversation

armno
Copy link
Contributor

@armno armno commented Nov 19, 2020

Recursive font seems to support ligatures. On the website it shows that it doesn't. This PR fixes that.

ligatures

Cheers,

@chriscoyier
Copy link
Contributor

You got a sec to re-run the screenshots and see if the work with the ligatures? We have a number of fonts I just couldn't get them working on #52 and I'd love to have a good example of them working to use to try to fix the others.

@armno
Copy link
Contributor Author

armno commented Nov 20, 2020

@chriscoyier here are screenshots generated with FONT='recursive' npm run screenshots command on my computer. I have ligatures working with Recursive font.

charmap-dark
charmap-light

However, with other fonts listed in #52, ligatures don't seem to work for them (tested with Hasklig and FiraFlott).

@chriscoyier chriscoyier merged commit e5bcf65 into CSS-Tricks:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants