Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lisa Cee #2

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
208 changes: 104 additions & 104 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,104 +1,104 @@
# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]
*$py.class

# C extensions
*.so

# Distribution / packaging
.Python
build/
develop-eggs/
dist/
downloads/
eggs/
.eggs/
lib/
lib64/
parts/
sdist/
var/
wheels/
*.egg-info/
.installed.cfg
*.egg
MANIFEST

# PyInstaller
# Usually these files are written by a python script from a template
# before PyInstaller builds the exe, so as to inject date/other infos into it.
*.manifest
*.spec

# Installer logs
pip-log.txt
pip-delete-this-directory.txt

# Unit test / coverage reports
htmlcov/
.tox/
.coverage
.coverage.*
.cache
nosetests.xml
coverage.xml
*.cover
.hypothesis/
.pytest_cache/

# Translations
*.mo
*.pot

# Django stuff:
*.log
local_settings.py
db.sqlite3

# Flask stuff:
instance/
.webassets-cache

# Scrapy stuff:
.scrapy

# Sphinx documentation
docs/_build/

# PyBuilder
target/

# Jupyter Notebook
.ipynb_checkpoints

# pyenv
.python-version

# celery beat schedule file
celerybeat-schedule

# SageMath parsed files
*.sage.py

# Environments
.env
.venv
env/
venv/
ENV/
env.bak/
venv.bak/

# Spyder project settings
.spyderproject
.spyproject

# Rope project settings
.ropeproject

# mkdocs documentation
/site

# mypy
.mypy_cache/
# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]
*$py.class
# C extensions
*.so
# Distribution / packaging
.Python
build/
develop-eggs/
dist/
downloads/
eggs/
.eggs/
lib/
lib64/
parts/
sdist/
var/
wheels/
*.egg-info/
.installed.cfg
*.egg
MANIFEST
# PyInstaller
# Usually these files are written by a python script from a template
# before PyInstaller builds the exe, so as to inject date/other infos into it.
*.manifest
*.spec
# Installer logs
pip-log.txt
pip-delete-this-directory.txt
# Unit test / coverage reports
htmlcov/
.tox/
.coverage
.coverage.*
.cache
nosetests.xml
coverage.xml
*.cover
.hypothesis/
.pytest_cache/
# Translations
*.mo
*.pot
# Django stuff:
*.log
local_settings.py
db.sqlite3
# Flask stuff:
instance/
.webassets-cache
# Scrapy stuff:
.scrapy
# Sphinx documentation
docs/_build/
# PyBuilder
target/
# Jupyter Notebook
.ipynb_checkpoints
# pyenv
.python-version
# celery beat schedule file
celerybeat-schedule
# SageMath parsed files
*.sage.py
# Environments
.env
.venv
env/
venv/
ENV/
env.bak/
venv.bak/
# Spyder project settings
.spyderproject
.spyproject
# Rope project settings
.ropeproject
# mkdocs documentation
/site
# mypy
.mypy_cache/
15 changes: 15 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
language: python # => 1
python: # => 2
- "2.6"
- "2.7"
services: # => 3
- mysql
env: # => 4
-DJANGO=1.8 DB=mysql
install: # => 5
- pip install -r requirements.txt
before_script: # => 6
- mysql -e 'create database test;' -u root
script: # => 7
script:
- python -m unittest test_module.py
2 changes: 2 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
{
}
38 changes: 38 additions & 0 deletions DeploymentExperiences.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
heroku deploy: https://dashboard.heroku.com/apps/lambda-reviews/access
https://lambda-reviews.herokuapp.com/

heroku deploy #2: https://lambda-reviews1.herokuapp.com/
django repo: https://github.com/LisaCee/Intro-Django


- Summarize the key steps in the deployment process.
- What went well?
I took time with this sprint-challenge to really read through the instructions before I tried to implement them. I think this lead to a more smooth deploy than I would have had if I had just jumped in and started installing new dependencies.

I thought that my deploy worked on the first attempt, but after visiting the app I discovered some errors. -- see challenges

- What challenges did you face?
I felt really anxious going into this challenge because it has been months since I've used Heroku and never with Django or Python.

My first challenge was that I couldn't get my local Heroku updated. I tried to run update, but it just got stuck in my terminal. Then I tried to reinstall Heroku, which appeared to work but my terminal still said I have an older version. I decided to continue without ensuring the update so that I could continue with the sprint in the given time.

Another challenge was the lack of benchmarks that this sprint provided. I could not make sure that everything was running correctly until I tried to deploy. I remedied this concern by pushing to Github frequently.

Finally I had a hard time understanding the instructions regarding database_url.
After struggling with it for a while, I found some helpful information at the end of the readme in the troubleshooting section.

*update* Heroku doesn't think Django is installed and that is causing a deploy error. I tried uninstalling from pip and reinstalling from pipenv as suggested in the readme, but so far that has not solved the issue. Failing to get a successful deploy is probably my biggest challenge. I redeployed under another app, lambda-reviews1 and that seems to have worked.

- How far did you get?
I think I have my project deployed. I haven’t yet been able to interact with it, since we were given no instructions on that, but Heroku gave me confirmation that my deploy was successful.

On second look though, while my upload was a success, the app site didn't work. I then refactored and created a new app that 'may' work. (I'm not sure what the final result should look like)

- We have utilized docs from several different projects over the course of this Sprint.
- Which docs did you think were the most helpful?
- Name one or two specific things about this resource that you think sets it apart from other docs you have referenced in the past.
I liked the Django docs, especially those listing the different fields available for models. It was nice having all of the options listed out in one place without having to dig around the site to find out about different types of fields (like date vs text).

While I didn’t use any new fields in my models, these docs empowered me to try something a little different in my project. I used Django validators (min and max) to customized my rating field.


1 change: 1 addition & 0 deletions Procfile
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
web: gunicorn reviews.wsgi --log-file -
Loading