Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend validation when updating user and update documentation #98

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Add backend validation when updating user and update documentation #98

merged 7 commits into from
Nov 13, 2024

Conversation

McNaBry
Copy link

@McNaBry McNaBry commented Nov 13, 2024 •
edited
Loading

Description

  • Add input validation when updating user on /api/user/users/:id route
  • Update documentation to document input validation, update examples and document new routes added to user service

Checklist

  • I have updated documentation
  • All tests passing

Screenshots (if applicable)

@McNaBry
Update user service README
c56766e 
* Add documentation for new routes to update username, email and password
* Modify examples to conform to format requirements
* Add new section detailing input format requirements
* Add input validation segment to relevant routes
@McNaBry
Add input validation for user service when updating user
760fd3e
@McNaBry McNaBry added documentation Improvements or additions to documentation service.User priority.Medium labels Nov 13, 2024
@McNaBry McNaBry self-assigned this Nov 13, 2024
@McNaBry McNaBry requested a review from samuelim01 November 13, 2024 13:08
samuelim01
samuelim01 approved these changes Nov 13, 2024
View reviewed changes
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

services/user/README.md Outdated Show resolved Hide resolved
@McNaBry McNaBry force-pushed the user-backend-validation branch from 6ae9800 to be14590 Compare November 13, 2024 13:30
@McNaBry McNaBry merged commit fdd794d into main Nov 13, 2024
6 checks passed
@McNaBry McNaBry deleted the user-backend-validation branch November 13, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelim01 samuelim01 samuelim01 approved these changes

Assignees

@McNaBry McNaBry

Labels
documentation Improvements or additions to documentation priority.Medium service.User
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McNaBry @samuelim01