Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fix on Question Service #42

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

KhoonSun47
Copy link

@KhoonSun47 KhoonSun47 commented Sep 28, 2024

Description

  • README: Update details on getTopics
  • questionController: Remove if check on getTopics

Checklist

  • I have updated documentation
  • All tests passing

Screenshots (if applicable)

- README: Update details on getTopics
- questionController: Remove if check on getTopics
@KhoonSun47 KhoonSun47 self-assigned this Sep 28, 2024
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelim01 samuelim01 merged commit e011fba into CS3219-AY2425S1:main Sep 28, 2024
2 checks passed
KhoonSun47 added a commit to KhoonSun47/cs3219-ay2425s1-project-g03 that referenced this pull request Sep 29, 2024
* main:
  Improve README and docker compose files (CS3219-AY2425S1#43)
  Update README and questionController.ts (CS3219-AY2425S1#42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants