Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDING-000] Feed thumbnail 조회 버그 수정 #207

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

KoSeonJe
Copy link
Collaborator

@KoSeonJe KoSeonJe commented Jan 12, 2025

🚀 작업 내용

thumbnail url 조회 시, 이미지 혹은 비디오 체크를 안하여 생긴 버그를 수정했습니다.

Summary by CodeRabbit

  • 리팩토링

    • 피드 목록 쿼리 생성 로직을 간소화하고 최적화했습니다.
    • 썸네일 정보 추출 방식을 개선하여 코드의 가독성을 높였습니다.
  • 버그 수정

    • 피드 유형에 따른 오류 처리 메커니즘을 강화했습니다.

@KoSeonJe KoSeonJe added the 🛠️버그 버그 제보 label Jan 12, 2025
@KoSeonJe KoSeonJe self-assigned this Jan 12, 2025
@KoSeonJe KoSeonJe merged commit 8f75593 into develop Jan 12, 2025
1 check passed
Copy link

coderabbitai bot commented Jan 12, 2025

Caution

Review failed

The pull request is closed.

"""

워크스루

FacadeFeedService 클래스에서 피드 목록 쿼리 생성 방식을 변경했습니다. 기존의 buildFeedListQuery 메서드를 제거하고, getFeedPageByClubgetNewestFeedPerClubPage 메서드 내에서 직접 FeedListQuery 인스턴스를 생성하도록 리팩토링했습니다. 새로 추가된 extractFeedThumbnailInfo 메서드를 통해 피드 유형에 따른 썸네일 정보 추출 로직을 단순화하고 통합했습니다.

변경 사항

파일 변경 내용
src/main/java/ddingdong/ddingdongBE/domain/feed/service/FacadeFeedService.java - buildFeedListQuery 메서드 제거
- extractFeedThumbnailInfo 메서드 추가
- 피드 처리 로직 스트림 방식으로 변경

제안된 라벨

🎯리팩토링, D-0

가능한 관련 PR

제안된 리뷰어

  • wonjunYou
  • 5uhwann
    """

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 329b585 and f85c08f.

📒 Files selected for processing (1)
  • src/main/java/ddingdong/ddingdongBE/domain/feed/service/FacadeFeedService.java (3 hunks)

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KoSeonJe KoSeonJe deleted the fix/feed branch January 12, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️버그 버그 제보
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant