Dockerfile.rlserver: update vissv2server target for VISSR v3 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing dockerfile originates from VISSR v2 and the vissv2server target has build and runtime issues when built under the current VISSR master branch, e.g. sha 11617fa, which has transitioned to VISSR v3. See Github issue COVESA#77 for details. This commit makes a first pass at bringing the vissv2server target build and runtime up to date for v3. Summary of changes: + protobuf root directory no longer exists. Remove. + vissv2.binary has been replaced by viss.him config file and the binary trees in the forest subdirectory. Copy those. + signaldimension.json has moved location. + introduce VISS json schema and file transfer test file. + fix FROM AS build time warnings related to case mismatches. These changes were successfully sanity tested within the COVESA Central Data Services Playground using the VISSR HTML client to get/set VSS data in the Apache IoTDB database backend. Possible remaining gaps: New features introduced in v3 such as file transfer are untested by the author. Some additional new files may be missing in the list of files copied. This commit has not attempted to address the VISSR AGT Server and Feeder targets. Additional work may be required to support those. Signed-off-by: Stephen Lawrence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing dockerfile originates from VISSR v2 and the vissv2server target has build and runtime issues when built under the current VISSR master branch, e.g. sha 11617fa, which has transitioned to VISSR v3. See Github issue #77 for details.
This commit makes a first pass at bringing the vissv2server target build and runtime up to date for v3.
Summary of changes:
These changes were successfully sanity tested within the COVESA Central Data Services Playground using the VISSR HTML client to get/set VSS data in the Apache IoTDB database backend.
Possible remaining gaps: New features introduced in v3 such as file transfer are untested by the author. Some additional new files may be missing in the list of files copied.
This commit has not attempted to address the VISSR AGT Server and Feeder targets. Additional work may be required to support those.