Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix streamid print in examples to make clear it is hex #71

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

SebastianSchildt
Copy link
Collaborator

Before

./acf-can-talker -i mon2 -d 16:93:3e:b3:5d:07 --canif vcan0 --stream-id=3735928559 --fd
acf-talker-configuration:
	Using NTSCF
	Using CAN FD interface: vcan0
	Using Ethernet
	Network Interface: mon2
	Destination MAC Address: 16:93:3e:b3:5d:07
	Talker Stream ID: 3735928559
	Number of ACF messages per AVTP frame in talker stream: 1

after

./acf-can-talker -i mon2 -d 16:93:3e:b3:5d:07 --canif vcan0 --stream-id=3735928559 --fd
...
	Talker Stream ID: 0x3735928559
...

which is better, because in the example the actual stream id is 237121996121 (0x3735928559)

@nayakned
Copy link
Collaborator

nayakned commented Jan 9, 2025

Looks good. Fixed similar issue for Zephyr acf-can-bridge.

@nayakned nayakned merged commit bf0e0e6 into COVESA:main Jan 9, 2025
1 check passed
@nayakned nayakned deleted the fix/streamidprintout branch January 9, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants