merge changes to deal with basic spatial components and big changes to chemsitry handling #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support to cb file with aux info
Merge spatial
Update logic for parsing custom_chemistries.json and permit_list_info.json
rewrite the unwrap in parsing expectedOri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes from the atac branch, but also includes @DongzeHE's implementation for handling 3 column barcode files and re-labling output for spatial data.
This also includes a major change to the handling of "custom" chemistries. The
custom_chemistries.jsonandpermit_info.jsonare being unified into a singlechemistries.jsonfile that is both more capable and also reduces the level of special-casing for built-in versus custom chemistries. Users will have to use the newchemistrycommand to update accordingly, and old chemistries may brake an need to be re-registered.