-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8231643
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to have your release script pull the actual version number from this file since the release page still shows v0.2.3 in the filename.
8231643
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh --- the release script still requires me to name things manually. I'll re-compile with the new version info. Thanks for catching this (and reminding me that the script should be more thoroughly automated ;P).
8231643
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok; fixed the releases. I'll think about how to best automate the release script. Thanks again.
8231643
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you thought about setting up some basic tests and running on @TravisCI? You can easily do deployment/releases on tagged commits in master branch etc...
8231643
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I've used @TravisCI for sailfish / salmon to run automated tests on commits etc. I haven't dug much yet into how to do deployment or releases yet. Specifically, the releases are built under Holy Build Box to ensure maximum compatibility, so I'd need some sort of travisci => docker setup etc.