Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade compiler requirement from C++11 to C++0x, to enable compati… #34

Conversation

hughperkins
Copy link

Downgrade compiler requirement from C++11 to C++0x, to enable compatibility with earlier versions of gcc, and with python 2.7 on Windows, and Python 3.4 on Windows

Addresses #33

…bility with earlier versions of gcc, and with python 2.7 on Windows, and Python 3.4 on Windows
@CNugteren
Copy link
Owner

Unless you have a specific compiler in mind for which this works, I will close this pull request. Tested myself with GCC 4.6 and that doesn't seem to work: it is missing too many C++11 features.

@CNugteren CNugteren closed this May 1, 2016
@hughperkins
Copy link
Author

The specific compiler is: msvc 2008. It's true that c++0x and msvc2008 are not terribly close though, so we could just look at ensuring that build on msvc2008 works.

@hughperkins
Copy link
Author

(or: at least, msvc2010; and I can build for msvc2008 in another way)

@CNugteren
Copy link
Owner

Yeah, OK, but this single 'fix' doesn't actually fix compilation in Visual Studio 2008. So, I think we should continue this discussion in the other issue or PR related to actual changes to the code base. In that case, I would propose to try to go to Visual Studio 2013 first, since that one is already missing many many C++11 features (https://msdn.microsoft.com/en-us/library/hh567368.aspx). If that will ever work, we can go back in history one step at a time.

@hughperkins
Copy link
Author

So, I think we should continue this discussion in the other issue or PR related to actual changes to the code base.

Yes thats fine for me

I would propose to try to go to Visual Studio 2013 first,

vs2013 doesnt really help me much: my goal is to build for python 2.7 or 3.4, wihch is msvc2008 and msvc2010.

I have submitted an initial PR for how the changes for msvc2008/2010 will look. They're quite radical, so not sure how willing you would be to accept those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants