Minor fixes in presentation

CMSTrackerDPG · Aug 12, 2022 · 43ff0cc · 43ff0cc
1 parent b933bd1
commit 43ff0cc
Showing 1 changed file with 19 additions and 10 deletions.
diff --git a/shiftleader/utilities/shiftleader_report_presentation.py b/shiftleader/utilities/shiftleader_report_presentation.py
@@ -568,13 +568,15 @@ def _generate_flag_changed_good_run_list_element(runs) -> Element:
                     text=self._format_list_to_str(runs.good().run_numbers()),
                     stylename=self.style_span_good,
                 )
+                spbl = Span(text=" ")
                 sp3 = Span(
                     text=self._format_list_to_str(runs.bad().run_numbers()),
                     stylename=self.style_span_bad,
                 )
                 sp4 = Span(text=")")
                 p.addElement(sp1)
                 p.addElement(sp2)
+                p.addElement(spbl)
                 p.addElement(sp3)
                 p.addElement(sp4)
 
@@ -659,18 +661,25 @@ def _add_page_summary(self):
 
     def _generate_daily_good_bad_run_list_element(self, day_queryset) -> Element:
         p = P()
-        sp0 = Span(text=f"{day_queryset.name()}: Good: ")
-        sp1 = Span(
-            text=self._format_list_to_str(
-                [run_number for run_number in day_queryset.good().run_numbers()]
-            ),
-            stylename=self.style_span_good,
-        )
-        p.addElement(sp0)
-        p.addElement(sp1)
+        sps = Span(text=f"{day_queryset.name()}: ")
+        p.addElement(sps)
+
+        if len(day_queryset.good().run_numbers()) > 0:
+            sp0 = Span(text="Good: ")
+            sp1 = Span(
+                text=self._format_list_to_str(
+                    [run_number for run_number in day_queryset.good().run_numbers()]
+                ),
+                stylename=self.style_span_good,
+            )
+            p.addElement(sp0)
+            p.addElement(sp1)
+            if len(day_queryset.bad().run_numbers()) > 0:
+                spbl = Span(text=" ")
+                p.addElement(spbl)
 
         if len(day_queryset.bad().run_numbers()) > 0:
-            sp2 = Span(text=f", Bad: ")
+            sp2 = Span(text=f"Bad: ")
             sp3 = Span(
                 text=self._format_list_to_str(
                     [run_number for run_number in day_queryset.bad().run_numbers()]