Add a way to pass input normal to faces #8638
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soesau
requested changes
Jan 7, 2025
| h=next(h, m_face_graph); | ||
| r=get(m_vpm,target(h, m_face_graph)); | ||
| } | ||
| while(!collinear(p,q,r)); |
There was a problem hiding this comment.
Suggested change
| while(!collinear(p,q,r)); | |
| while(collinear(p,q,r)); |
| to chunks of faces in a polygon mesh and controls the quality of this fit. | ||
| If all quality conditions are satisfied, the chunk is accepted as a valid region, | ||
| otherwise rejected. | ||
|
|
There was a problem hiding this comment.
Doc needs to be updated. The region is based on the support plane of the seed face.
| const Item query, | ||
| const Region&) const | ||
| { | ||
| //TODO: that's a bit dummy that we retest points that are already in the region... |
There was a problem hiding this comment.
If performance is an issue, we can add a flag that is set when the region needs to be rechecked. But this region type should be pretty fast already as there is no refitting.
| const typename GeomTraits::Point_3& p=get(m_vpm,source(h, m_face_graph)); | ||
| const typename GeomTraits::Point_3& q=get(m_vpm,target(h, m_face_graph)); | ||
| typename GeomTraits::Point_3 r; | ||
| //TODO: add safety checks for degenerate faces |
There was a problem hiding this comment.
The safety check should be inside the update method that should return false for degenerate faces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid computing them when they are known.
sort()for exemple). PCA is also used here to estimate the flatness score of a face in its neighborhood