Correction of (X)HTML warnings in case of Advanced topics #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on CGAL#3713 a number of problems were solved, but also some new issues introduced. - BaseDoxyfile.h see to it that the CGALAdvancedBegin is in a detailed part, so be sure to terminate the brief part by an extra carriage return - commands like \pre, \note read till the beginning of the next section but a \htmlonly is not seen as a section separator, so insert an extra carriage return - some places missed an "Advanced" indicator, used the cgalAdvancedType here. ##Note in Periodic_2_triangulation_2.h there appear to be a number of images that are a bit in thin air (Captions: "Insertion of a point on an edge." and "Insertion in a face."). Also just above these images theer are a number of functions that have documentation, but this is non-doxygen documentation and as such not seen by doxygen
sloriot
reviewed
Mar 15, 2019
|
I think this would be possible, but I didn't test it. |
|
Shall I make the change so that you can test it? |
|
I can update the pull request, so I can directly test it. |
Based on suggestion of @sloriot using `^^` also in cgalAdvancedEnd instead of adding a new line in the files
|
Added new commit based on suggestion by @sloriot. |
sloriot
approved these changes
Mar 15, 2019
lrineau
added
the
Not yet approved
|
Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-4.14-Ic-151.shtml |
lrineau
added
rm only: ready for master
lrineau
added a commit
that referenced
this pull request
Mar 19, 2019
Correction of (X)HTML warnings in case of Advanced topics
lrineau
removed
Not yet approved
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Based on #3713 a number of problems were solved, but also some new issues introduced.
Note
in Periodic_2_triangulation_2.h there appear to be a number of images that are a bit in thin air (Captions: "Insertion of a point on an edge." and "Insertion in a face.").
Also just above these images there are a number of functions that have documentation, but this is non-doxygen documentation and as such not seen by doxygen