Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for RunPython #485

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

llaniewski
Copy link
Member

This PR:

  • introduces an example xml case which uses RunPython to construct vtkImageData and write it to disk.
  • fixes and error in RunR occurring when accessing .si quantities
  • converting R factors (eg. components of geometry) to numpy arrays of integers, shifted by 1, to make it consistent with python indexing. Previously an array of strings was visible in python, which was very inefficient. (FYI: @shkodm)

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36c4007) 44.46% compared to head (614f37d) 44.46%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   44.46%   44.46%           
=======================================
  Files         166      166           
  Lines        7536     7536           
=======================================
  Hits         3351     3351           
  Misses       4185     4185           
Flag Coverage Δ
d2q9 31.92% <ø> (ø)
d3q27_PSM_NEBB 36.53% <ø> (ø)
d3q27_pf_velocity 30.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@llaniewski llaniewski merged commit f7f36f7 into CFD-GO:master Jan 10, 2024
53 checks passed
@llaniewski llaniewski deleted the feature/runpython branch January 16, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants