Update spline kernels with improvements from SLL #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpadioleau
reviewed
Mar 23, 2024
|
Thanks a lot for this MR |
blegouix
reviewed
Mar 26, 2024
blegouix
reviewed
Mar 26, 2024
tpadioleau
force-pushed
the
ddc_update_greville
branch
from
9a5088d to
add04fd
Compare
tpadioleau
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update spline kernels with improvements from SLL. For most files this only concerns documentation. However for
include/ddc/kernels/splines/greville_interpolation_points.hppthere is a bug fix. The periodic point must be calcucated in the helper class in order to be able to evaluate the length of the domain.