cli BUGFIX memory leak in linenoise and readinput

CESNET · Jan 7, 2025 · c79167c · c79167c
1 parent 18a2e17
commit c79167c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/cli/completion.c b/cli/completion.c
@@ -323,15 +323,15 @@ readinput(const char *instruction, const char *old_tmp, char **new_tmp)
         }
     }
 
+cleanup:
+
     if (new_tmp) {
         *new_tmp = tmpname;
     } else {
         unlink(tmpname);
         free(tmpname);
     }
 
-cleanup:
-
     close(tmpfd);
     free(old_content);
 

diff --git a/cli/linenoise/linenoise.c b/cli/linenoise/linenoise.c
@@ -1044,8 +1044,10 @@ char *linenoiseHistoryDataGet() {
 
 static void linenoiseHistItemFree(int hist_idx) {
     free(history[hist_idx].line);
+    history[hist_idx].line = NULL;
     if (hist_data_free_clb) {
         hist_data_free_clb(history[hist_idx].data);
+        history[hist_idx].data = NULL;
     }
 }