Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS refactor #227

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

TLS refactor #227

wants to merge 6 commits into from

Conversation

Zadamsa
Copy link
Contributor

@Zadamsa Zadamsa commented Nov 4, 2024

No description provided.

process/tls_parser.cpp Outdated Show resolved Hide resolved
process/tls_parser.cpp Outdated Show resolved Hide resolved
process/tls_parser.cpp Outdated Show resolved Hide resolved
process/tls_parser.hpp Outdated Show resolved Hide resolved
@Zadamsa Zadamsa force-pushed the tls-refactor branch 5 times, most recently from 123d004 to dd4966c Compare November 23, 2024 17:33
process/tls_parser.cpp Outdated Show resolved Hide resolved
process/tls_parser.cpp Outdated Show resolved Hide resolved
@Zadamsa Zadamsa force-pushed the tls-refactor branch 3 times, most recently from 388d807 to 914717f Compare December 2, 2024 00:47
@SiskaPavel
Copy link
Contributor

Udelej rebase + oprav buildovani a ja to nasadim na test

process/tls_parser.hpp Outdated Show resolved Hide resolved
process/sha256.hpp Show resolved Hide resolved
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.03911% with 177 lines in your changes missing coverage. Please review.

Project coverage is 41.55%. Comparing base (70e7cc2) to head (a2dabe6).

Files with missing lines Patch % Lines
process/tls_parser.cpp 66.41% 39 Missing and 49 partials ⚠️
process/tls.cpp 70.27% 31 Missing and 13 partials ⚠️
process/tls.hpp 17.24% 22 Missing and 2 partials ⚠️
process/sha256.hpp 81.57% 5 Missing and 9 partials ⚠️
process/quic_parser.cpp 68.18% 3 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   40.78%   41.55%   +0.77%     
==========================================
  Files         104      105       +1     
  Lines       10124    10307     +183     
  Branches     1492     1489       -3     
==========================================
+ Hits         4129     4283     +154     
- Misses       5130     5163      +33     
+ Partials      865      861       -4     
Flag Coverage Δ
tests 41.55% <67.03%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -7,19 +7,15 @@
* \brief Class for parsing TLS traffic.
* \author Andrej Lukacovic [email protected]
* \author Karel Hynek <[email protected]>
* \date 2022
* \author Zainullin Damir <[email protected]>
* \date 2024
*/

#include "tls_parser.hpp"
#include <endian.h>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chybi ti tady hromada includu (ale i v ostatnich souborech).
Projdi prosimte soubory a vse potrebne co neni v .hpp dopln.

S novejsi verzi gcc to ani nejde prelozit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants