Fix issue in block sizing for GPU shared basis #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylt
approved these changes
Jan 14, 2025
jeremylt
reviewed
Jan 14, 2025
zatkins-dev
force-pushed
the
zach/hip-nontensor-fix
branch
from
226addc to
97011ea
Compare
jeremylt
approved these changes
Jan 14, 2025
|
Figured out why: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a crash when applying a
CeedBasiswith eval typeCEED_EVAL_WEIGHTfor order 2 elements.I'm not sure if the cuda change is also necessary?