Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hip/shared NonTensor #1724

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix hip/shared NonTensor #1724

merged 1 commit into from
Jan 13, 2025

Conversation

jeremylt
Copy link
Member

Thought I had these. Oops

@jeremylt jeremylt requested a review from zatkins-dev January 13, 2025 21:27
@jeremylt jeremylt self-assigned this Jan 13, 2025
@jeremylt jeremylt force-pushed the jeremy/fix-hip-shared branch 2 times, most recently from 844f0d3 to 371bb58 Compare January 13, 2025 21:31
@jeremylt jeremylt force-pushed the jeremy/fix-hip-shared branch from 371bb58 to 2d217ac Compare January 13, 2025 21:32
Copy link
Collaborator

@zatkins-dev zatkins-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test at the moment, but I think think looks good to me. If you can run ratel tests with this locally, I would say it's good.

@jeremylt
Copy link
Member Author

The only issue should be shared data limits on whatever card is being used

@jeremylt jeremylt merged commit d01feaa into main Jan 13, 2025
28 checks passed
@jeremylt jeremylt deleted the jeremy/fix-hip-shared branch January 13, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants