-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy RTC compilation of MAGMA basis kernels for small P, Q #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes JiT upgrades for Magma non-tensor basis to only compile for N values which are used at runtime. Adds JiT for Magma non-tensor basis CEED_EVAL_WEIGHT mode.
sebastiangrimberg
force-pushed
the
sjg/magma-formatting-dev
branch
from
October 17, 2023 21:20
1cac276
to
940a72f
Compare
Indeed this PR resolves #1373: Before: After: |
jeremylt
reviewed
Oct 17, 2023
jeremylt
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for these changes!
Looks like the only CI issue is a -0.05% coverage change (noise). So I think this can be merged when ready. |
sebastiangrimberg
added a commit
that referenced
this pull request
Oct 17, 2023
jrwrigh
added a commit
that referenced
this pull request
Oct 18, 2023
Remove accidental WIP tuning files from #1382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored preliminary PR for #1301. Compiles custom non-tensor MAGMA kernels only when needed (during first call to CeedBasisApply).
Other included improvements to the
magma
backend:magma
backend to match the other GPU backends in the library, along with other style formatting for consistency with other backends and the style guide (variable casing, for example).ceed-magma.h
to eliminate duplication between tensor and non-tensor basis code.jit-source/magma
files as done in Style fixes forcuda
andhip
backend consistency #1299 forcuda
andhip
backends.CEED_EVAL_WEIGHT
in themagma
backend (as forcuda/ref
andhip/ref
).TODO
/gpu/*/magma
backends #1373