Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy RTC compilation of MAGMA basis kernels for small P, Q #1382

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

sebastiangrimberg
Copy link
Collaborator

@sebastiangrimberg sebastiangrimberg commented Oct 17, 2023

Refactored preliminary PR for #1301. Compiles custom non-tensor MAGMA kernels only when needed (during first call to CeedBasisApply).

Other included improvements to the magma backend:

  • Renames files in the magma backend to match the other GPU backends in the library, along with other style formatting for consistency with other backends and the style guide (variable casing, for example).
  • Simplify some of the macro definitions in ceed-magma.h to eliminate duplication between tensor and non-tensor basis code.
  • Add include guards to jit-source/magma files as done in Style fixes for cuda and hip backend consistency #1299 for cuda and hip backends.
  • Use JiT for the non-tensor weight kernels for the CEED_EVAL_WEIGHT in the magma backend (as for cuda/ref and hip/ref).

TODO

Includes JiT upgrades for Magma non-tensor basis to only compile for N values which are used at runtime. Adds JiT for Magma non-tensor basis CEED_EVAL_WEIGHT mode.
@sebastiangrimberg
Copy link
Collaborator Author

Indeed this PR resolves #1373:

Before:

Screenshot 2023-10-17 at 2 45 22 PM

After:

Screenshot 2023-10-17 at 2 46 28 PM

Copy link
Member

@jeremylt jeremylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for these changes!

@sebastiangrimberg
Copy link
Collaborator Author

Looks like the only CI issue is a -0.05% coverage change (noise). So I think this can be merged when ready.

@jeremylt jeremylt merged commit db7ade3 into main Oct 17, 2023
@jeremylt jeremylt deleted the sjg/magma-formatting-dev branch October 17, 2023 22:54
jrwrigh added a commit that referenced this pull request Oct 18, 2023
Remove accidental WIP tuning files from #1382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants