Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluids: Add external SGS DD inference capability #1361

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Conversation

jrwrigh
Copy link
Collaborator

@jrwrigh jrwrigh commented Oct 3, 2023

This adds the capability to use external libraries to do the inference of the SGS DD model. Currently, this is just a framework with the native libCEED inference method enabled. External libraries will be added in later.

More verbosely, this introduces to different ways to evaluate the data-driven SGS model: fused and sequential.

Fused is what was implemented before, where the input creation, model inference, and output handling were all done in a single CeedOperator. This requires a native libCEED inference implementation.

Sequential has separate function calls/CeedOperators for input creation, model inference, and output handling. This allows for functions calling external libraries to be used for the model inference step.

Closes #1326

@jrwrigh jrwrigh self-assigned this Oct 3, 2023
@jrwrigh jrwrigh force-pushed the jrwrigh/external_sgs branch 2 times, most recently from fd755fe to f572ef1 Compare October 3, 2023 22:18
@jrwrigh jrwrigh added 0-WIP and removed 1-In Review labels Oct 3, 2023
@jrwrigh jrwrigh force-pushed the jrwrigh/external_sgs branch 2 times, most recently from 25dcfbd to e6e17ec Compare October 3, 2023 22:44
@jrwrigh jrwrigh force-pushed the jrwrigh/external_sgs branch from 2f1821c to fe3d5b7 Compare October 11, 2023 22:41
@jrwrigh jrwrigh added 1-In Review and removed 0-WIP labels Oct 11, 2023
@jrwrigh jrwrigh force-pushed the jrwrigh/external_sgs branch 2 times, most recently from de7cb48 to e118d22 Compare October 16, 2023 20:03
@jrwrigh jrwrigh requested review from jedbrown and jeremylt October 16, 2023 20:06
@jrwrigh jrwrigh force-pushed the jrwrigh/external_sgs branch from e118d22 to d91fd0b Compare November 27, 2023 20:26
@jrwrigh jrwrigh force-pushed the jrwrigh/external_sgs branch from d91fd0b to 36adc5d Compare December 5, 2023 22:08
@jrwrigh jrwrigh force-pushed the jrwrigh/external_sgs branch from 36adc5d to ca4ebe0 Compare February 22, 2024 02:18
jrwrigh added 4 commits March 1, 2024 07:22
- Existing implementation now called "Fused" evaluation
- PascalCase for acronyms longer than 2 letters
- Remove the "Anisotropic" qualifier from function names, as we only
  have one data-driven SGS model. If we add an isotropic model later, we
  can give that the "Isotropic" qualifier on it's function names
- Remove the "Model" qualifier from function names. "SgsDD" is
  communicative enough (Subgrid-stress inherently means a model)
@jrwrigh jrwrigh force-pushed the jrwrigh/external_sgs branch 2 times, most recently from 5cdf7f3 to a38bb46 Compare March 1, 2024 14:28
@jeremylt
Copy link
Member

jeremylt commented Mar 5, 2024

Is this still planning on being merged? Looks reasonable to me

@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Mar 5, 2024

Yep, it's been ready for review for a couple months, but also isn't pressing. (though it'd be nice to go ahead and have it merged in obviously).

@jrwrigh jrwrigh force-pushed the jrwrigh/external_sgs branch from 2d10162 to 80dc807 Compare March 5, 2024 22:20
@jrwrigh jrwrigh force-pushed the jrwrigh/external_sgs branch from 80dc807 to d7af081 Compare March 5, 2024 22:21
@jrwrigh jrwrigh merged commit 82a64ec into main Mar 5, 2024
27 of 28 checks passed
@jrwrigh jrwrigh deleted the jrwrigh/external_sgs branch March 5, 2024 22:44
@jedbrown
Copy link
Member

jedbrown commented Mar 5, 2024

Thanks @jrwrigh for developing this feature and @jeremylt for reviewing.

@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Mar 5, 2024

Welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fluids: Allow for external DD inference for SGS model
3 participants