-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fluids: Add external SGS DD inference capability #1361
Merged
Merged
+463
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrwrigh
force-pushed
the
jrwrigh/external_sgs
branch
2 times, most recently
from
October 3, 2023 22:18
fd755fe
to
f572ef1
Compare
jrwrigh
force-pushed
the
jrwrigh/external_sgs
branch
2 times, most recently
from
October 3, 2023 22:44
25dcfbd
to
e6e17ec
Compare
jrwrigh
force-pushed
the
jrwrigh/external_sgs
branch
from
October 11, 2023 22:41
2f1821c
to
fe3d5b7
Compare
jrwrigh
force-pushed
the
jrwrigh/external_sgs
branch
2 times, most recently
from
October 16, 2023 20:03
de7cb48
to
e118d22
Compare
jeremylt
reviewed
Oct 16, 2023
jrwrigh
force-pushed
the
jrwrigh/external_sgs
branch
from
November 27, 2023 20:26
e118d22
to
d91fd0b
Compare
jrwrigh
force-pushed
the
jrwrigh/external_sgs
branch
from
December 5, 2023 22:08
d91fd0b
to
36adc5d
Compare
jrwrigh
force-pushed
the
jrwrigh/external_sgs
branch
from
February 22, 2024 02:18
36adc5d
to
ca4ebe0
Compare
- Existing implementation now called "Fused" evaluation
- It doesn't need anything more than that
- PascalCase for acronyms longer than 2 letters - Remove the "Anisotropic" qualifier from function names, as we only have one data-driven SGS model. If we add an isotropic model later, we can give that the "Isotropic" qualifier on it's function names - Remove the "Model" qualifier from function names. "SgsDD" is communicative enough (Subgrid-stress inherently means a model)
jrwrigh
force-pushed
the
jrwrigh/external_sgs
branch
2 times, most recently
from
March 1, 2024 14:28
5cdf7f3
to
a38bb46
Compare
Is this still planning on being merged? Looks reasonable to me |
Yep, it's been ready for review for a couple months, but also isn't pressing. (though it'd be nice to go ahead and have it merged in obviously). |
jeremylt
reviewed
Mar 5, 2024
jeremylt
approved these changes
Mar 5, 2024
jrwrigh
force-pushed
the
jrwrigh/external_sgs
branch
from
March 5, 2024 22:20
2d10162
to
80dc807
Compare
jrwrigh
force-pushed
the
jrwrigh/external_sgs
branch
from
March 5, 2024 22:21
80dc807
to
d7af081
Compare
Welcome! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the capability to use external libraries to do the inference of the SGS DD model. Currently, this is just a framework with the native libCEED inference method enabled. External libraries will be added in later.
More verbosely, this introduces to different ways to evaluate the data-driven SGS model: fused and sequential.
Fused is what was implemented before, where the input creation, model inference, and output handling were all done in a single CeedOperator. This requires a native libCEED inference implementation.
Sequential has separate function calls/CeedOperators for input creation, model inference, and output handling. This allows for functions calling external libraries to be used for the model inference step.
Closes #1326