Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluids: SmartSim Online Data-Driven SGS training #1203

Merged
merged 14 commits into from
Nov 27, 2023
Merged

fluids: SmartSim Online Data-Driven SGS training #1203

merged 14 commits into from
Nov 27, 2023

Conversation

jrwrigh
Copy link
Collaborator

@jrwrigh jrwrigh commented Apr 20, 2023 •
edited
Loading

Todo:

  • Documentation
  • Send subgrid stresses (not just filtered velocity products)
    • Add SGS to dd training input DM
    • Add calculation of subgrid stress to training input calculation
    • Verify DM Vec data placement (if true, remove IS and copying mechanics)
  • Add test

Depends on #1223

@jrwrigh jrwrigh force-pushed the jrwrigh/smartsim branch 4 times, most recently from 39d4bcc to b8747ff Compare April 25, 2023 17:06
@jrwrigh jrwrigh force-pushed the jrwrigh/smartsim branch 9 times, most recently from 4c18a6f to 70277b9 Compare May 5, 2023 14:27
@jrwrigh jrwrigh force-pushed the jrwrigh/smartsim branch from 70277b9 to 5380fcd Compare May 14, 2023 03:02
@jrwrigh jrwrigh force-pushed the jrwrigh/differential_filter branch from 24271ad to 3bfc51f Compare May 18, 2023 02:53
@jrwrigh jrwrigh force-pushed the jrwrigh/smartsim branch 3 times, most recently from afba1e7 to c435b71 Compare May 25, 2023 23:32
@jrwrigh jrwrigh force-pushed the jrwrigh/differential_filter branch from 3bfc51f to 8400f94 Compare May 30, 2023 22:50
@jrwrigh jrwrigh force-pushed the jrwrigh/smartsim branch 3 times, most recently from b26bb54 to 8837361 Compare May 31, 2023 21:27
Base automatically changed from jrwrigh/differential_filter to main June 5, 2023 13:11
@jrwrigh jrwrigh mentioned this pull request Jun 5, 2023
Merged
@jrwrigh jrwrigh force-pushed the jrwrigh/smartsim branch 6 times, most recently from b4e2603 to 36b1d88 Compare June 8, 2023 20:02
@jrwrigh jrwrigh self-assigned this Oct 11, 2023
@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Oct 11, 2023

I hereby declare this PR officially good for review!

@jrwrigh jrwrigh force-pushed the jrwrigh/smartsim branch 3 times, most recently from 1c9cc74 to 95b1a41 Compare October 16, 2023 18:39
@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Oct 16, 2023

Alright, I've reviewed over this and rebased onto main. Good to review. @jedbrown @jeremylt

jedbrown
jedbrown approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@jedbrown jedbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the testing working and Ratel compat checked, I think this can merge.

jrwrigh added 14 commits November 27, 2023 13:40
@jrwrigh
fluids: Agnosticize VeloGradient projection setup
7618d7b 
 - It can now setup more than just user->grad_velo_proj
@jrwrigh
fluids: Store diff filter field ids
051427e
@jrwrigh
fluids: Add DMGet{Global,Local}VectorInfo to public header
650a5d6
@jrwrigh
fluids: Add SmartSim build to Makefile
fc818f1
@jrwrigh
fluids: Add SmartSim setup
8146534 
- Adds `-smartsim_diable_calls` which can run with `-sgs_train_enable`,
  but doesn't call SmartSim library calls. This allows for debugging the
  training related functions without having to run inside a SmartSim
  experiment.
@jrwrigh
fluids: Move diff filter enums to separate header file
7c00069 
- So that other QFunctions can use them for indexing into differential
  filtered fields
@jrwrigh
fluids: Add SGS DD training QFunctions
e654ecc 
- Returns training data
@jrwrigh
fluids: Add data-driven SGS training setup, TSMonitor
ee3b213 
- Adds `smartsim_weak.c` to handle case where SmartRedis is not built
@jrwrigh
fluids: Add TSPostStep for SGS DD Training
1a7db67 
- This will shutdown the simulation if there's a tensor called
  `check-run` equal to zeros
@jrwrigh
fluids: Add -sgs_train_enable flag
28134cf
@jrwrigh
doc(fluids): Document SmartSim in situ training
3b219b8
@jrwrigh
fluids: Add smartsim regression testing
e17e35b 
Requires that the fluids code be built with SMARTREDIS_DIR set, and in
an environment with SmartSim (Python library) installed as well.

Co-authored by: Zach Atkins <[email protected]>
@jrwrigh
fluids: Add SmartSimDataDestroy
b306c3f
@jrwrigh
fluids: Change SmartRedisCall -> PetscSmartRedisCall
4e139b5
@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Nov 27, 2023

Thanks! I've changed the SmartRedisCall to PetscSmartRedisCall as Jeremy suggested. I've also rebased onto main just to make sure everything is working correctly CI-wise.

@jrwrigh jrwrigh merged commit 3451ca5 into main Nov 27, 2023
26 checks passed
@jrwrigh jrwrigh deleted the jrwrigh/smartsim branch November 27, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zatkins-dev zatkins-dev zatkins-dev left review comments

@jeremylt jeremylt jeremylt left review comments

@jedbrown jedbrown jedbrown approved these changes

Assignees

@jrwrigh jrwrigh

Labels
1-In Review examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrwrigh @jedbrown @jeremylt @zatkins-dev