Refactor Preconditioning Ingredients (#795)

* op - split preconditioning into separate file * pc - move FDM to interface level * pc - initial move of diagonal assembly to interface * interface - only return error code or error * doc - improve preconditioning helper function documentation * pc - use qdata layout for interface diagonal assembly * pc - update for consistency in naming, use of CeedChk, and static * doc - spelling * style - minor * doc - add doc for CeedBuildMassLaplace * doc - update release notes Co-authored-by: Jed Brown <[email protected]> Co-authored-by: Jed Brown <[email protected]>
CEED · Aug 2, 2021 · eaf62ff · eaf62ff
1 parent 77ac943
commit eaf62ff
Show file tree

Hide file tree

Showing 12 changed files with 2,026 additions and 1,963 deletions.
diff --git a/backends/cuda-gen/ceed-cuda-gen-operator.c b/backends/cuda-gen/ceed-cuda-gen-operator.c
@@ -191,19 +191,6 @@ static int CeedOperatorApplyAdd_Cuda_gen(CeedOperator op, CeedVector invec,
   return CEED_ERROR_SUCCESS;
 }
 
-//------------------------------------------------------------------------------
-// Create FDM element inverse not supported
-//------------------------------------------------------------------------------
-static int CeedOperatorCreateFDMElementInverse_Cuda(CeedOperator op) {
-  // LCOV_EXCL_START
-  int ierr;
-  Ceed ceed;
-  ierr = CeedOperatorGetCeed(op, &ceed); CeedChkBackend(ierr);
-  return CeedError(ceed, CEED_ERROR_BACKEND,
-                   "Backend does not implement FDM inverse creation");
-  // LCOV_EXCL_STOP
-}
-
 //------------------------------------------------------------------------------
 // Create operator
 //------------------------------------------------------------------------------
@@ -216,9 +203,6 @@ int CeedOperatorCreate_Cuda_gen(CeedOperator op) {
   ierr = CeedCalloc(1, &impl); CeedChkBackend(ierr);
   ierr = CeedOperatorSetData(op, impl); CeedChkBackend(ierr);
 
-  ierr = CeedSetBackendFunction(ceed, "Operator", op, "CreateFDMElementInverse",
-                                CeedOperatorCreateFDMElementInverse_Cuda);
-  CeedChkBackend(ierr);
   ierr = CeedSetBackendFunction(ceed, "Operator", op, "ApplyAdd",
                                 CeedOperatorApplyAdd_Cuda_gen); CeedChkBackend(ierr);
   ierr = CeedSetBackendFunction(ceed, "Operator", op, "Destroy",

diff --git a/backends/cuda/ceed-cuda-operator.c b/backends/cuda/ceed-cuda-operator.c
@@ -1201,19 +1201,6 @@ static int CeedOperatorLinearAssembleAddPointBlockDiagonal_Cuda(CeedOperator op,
   }
 }
 
-//------------------------------------------------------------------------------
-// Create FDM element inverse not supported
-//------------------------------------------------------------------------------
-static int CeedOperatorCreateFDMElementInverse_Cuda(CeedOperator op) {
-  // LCOV_EXCL_START
-  int ierr;
-  Ceed ceed;
-  ierr = CeedOperatorGetCeed(op, &ceed); CeedChkBackend(ierr);
-  return CeedError(ceed, CEED_ERROR_BACKEND,
-                   "Backend does not implement FDM inverse creation");
-  // LCOV_EXCL_STOP
-}
-
 //------------------------------------------------------------------------------
 // Create operator
 //------------------------------------------------------------------------------
@@ -1236,9 +1223,6 @@ int CeedOperatorCreate_Cuda(CeedOperator op) {
                                 "LinearAssembleAddPointBlockDiagonal",
                                 CeedOperatorLinearAssembleAddPointBlockDiagonal_Cuda);
   CeedChkBackend(ierr);
-  ierr = CeedSetBackendFunction(ceed, "Operator", op, "CreateFDMElementInverse",
-                                CeedOperatorCreateFDMElementInverse_Cuda);
-  CeedChkBackend(ierr);
   ierr = CeedSetBackendFunction(ceed, "Operator", op, "ApplyAdd",
                                 CeedOperatorApplyAdd_Cuda); CeedChkBackend(ierr);
   ierr = CeedSetBackendFunction(ceed, "Operator", op, "Destroy",

diff --git a/backends/hip-gen/ceed-hip-gen-operator.c b/backends/hip-gen/ceed-hip-gen-operator.c
@@ -192,19 +192,6 @@ static int CeedOperatorApplyAdd_Hip_gen(CeedOperator op, CeedVector invec,
   return CEED_ERROR_SUCCESS;
 }
 
-//------------------------------------------------------------------------------
-// Create FDM element inverse not supported
-//------------------------------------------------------------------------------
-static int CeedOperatorCreateFDMElementInverse_Hip(CeedOperator op) {
-  // LCOV_EXCL_START
-  int ierr;
-  Ceed ceed;
-  ierr = CeedOperatorGetCeed(op, &ceed); CeedChkBackend(ierr);
-  return CeedError(ceed, CEED_ERROR_BACKEND,
-                   "Backend does not implement FDM inverse creation");
-  // LCOV_EXCL_STOP
-}
-
 //------------------------------------------------------------------------------
 // Create operator
 //------------------------------------------------------------------------------
@@ -217,9 +204,6 @@ int CeedOperatorCreate_Hip_gen(CeedOperator op) {
   ierr = CeedCalloc(1, &impl); CeedChkBackend(ierr);
   ierr = CeedOperatorSetData(op, impl); CeedChkBackend(ierr);
 
-  ierr = CeedSetBackendFunction(ceed, "Operator", op, "CreateFDMElementInverse",
-                                CeedOperatorCreateFDMElementInverse_Hip);
-  CeedChkBackend(ierr);
   ierr = CeedSetBackendFunction(ceed, "Operator", op, "ApplyAdd",
                                 CeedOperatorApplyAdd_Hip_gen); CeedChkBackend(ierr);
   ierr = CeedSetBackendFunction(ceed, "Operator", op, "Destroy",

diff --git a/backends/hip/ceed-hip-operator.c b/backends/hip/ceed-hip-operator.c
@@ -1201,18 +1201,6 @@ static int CeedOperatorLinearAssembleAddPointBlockDiagonal_Hip(CeedOperator op,
   }
 }
 
-//------------------------------------------------------------------------------
-// Create FDM element inverse not supported
-//------------------------------------------------------------------------------
-static int CeedOperatorCreateFDMElementInverse_Hip(CeedOperator op) {
-  // LCOV_EXCL_START
-  int ierr;
-  Ceed ceed;
-  ierr = CeedOperatorGetCeed(op, &ceed); CeedChkBackend(ierr);
-  return CeedError(ceed, CEED_ERROR_BACKEND,
-                   "Backend does not implement FDM inverse creation");
-  // LCOV_EXCL_STOP
-}
 
 //------------------------------------------------------------------------------
 // Create operator
@@ -1236,9 +1224,6 @@ int CeedOperatorCreate_Hip(CeedOperator op) {
                                 "LinearAssembleAddPointBlockDiagonal",
                                 CeedOperatorLinearAssembleAddPointBlockDiagonal_Hip);
   CeedChkBackend(ierr);
-  ierr = CeedSetBackendFunction(ceed, "Operator", op, "CreateFDMElementInverse",
-                                CeedOperatorCreateFDMElementInverse_Hip);
-  CeedChkBackend(ierr);
   ierr = CeedSetBackendFunction(ceed, "Operator", op, "ApplyAdd",
                                 CeedOperatorApplyAdd_Hip); CeedChkBackend(ierr);
   ierr = CeedSetBackendFunction(ceed, "Operator", op, "Destroy",