Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rjd0 val params #247

Merged
merged 6 commits into from
Jan 11, 2025
Merged

Rjd0 val params #247

merged 6 commits into from
Jan 11, 2025

Conversation

RamiyapriyaS
Copy link
Collaborator

Description

  • Removed legacy code in the VALIDATE_PARAMS process
  • Updated the nextflow_schema.json file to search for file patterns in input parameters
  • Updated Readme to indicate nf-schema warning message

Checklist

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out? Yes
    • Does it produce the expected outputs, given the inputs provided? Yes
  • Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • [N/A] Did you check for sensitive data, and remove any?
  • [N/A] If you added or modified HTML, did you check that it was 508 compliant?

@RamiyapriyaS
Copy link
Collaborator Author

Issue addressed in this PR: #234

Copy link
Collaborator

@jessicarowell jessicarowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the validation plugin directly into the workflow script to simplify things a bit, and deleted the validate_params module which is no longer needed.

@jessicarowell jessicarowell merged commit 4c6846a into dev Jan 11, 2025
@jessicarowell jessicarowell deleted the rjd0-val-params branch January 11, 2025 07:41
@jessicarowell jessicarowell modified the milestone: v4.1.1 Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Internal] [Bug] User config plugins will be ignored: [email protected] and invalid input values
2 participants