generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expect Single Sample FASTA Files (Issue #82) #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e intuitive and broadly applicable + changed the default value for virus to true (will run the virus profile by default)
…ion_only to something more intuitive and broadly applicable
…d the entry_flag since not being used
… used + removed the entry_ prefix and changed the name for ENTRY_SUBMISSION to GENERAL_SUBMISSION
…test param name changes)
…nger needed + put logic for checking whether one of the annotations are set to true, if not then assume user provided annotations are given
…CDCgov/tostadas into 82-internal-enhance-split-fasta
…s are checked and location + copied over with changed names
…tored after name check and that it exists at fasta_path
… custom fields and the fasta field too
…ring metadata validation step
…ow include fastas from metadata validation and not from annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please Describe the Bug(s) Fixed and/or the Feature(s) Added:
Added functionality to expect / handle multiple single FASTA files (1 per sample).
Checklist
Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed
General Checks
Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?
For each relevant configuration:
Have you conducted proper linting procedures?
Have you updated existing documentation (README.md, etc.) or created new ones within docs?
CDC Checks
Are additional approvals needed for this change? If so, please mention them below:
No.
Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:
No.