Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Bakta refactor into Dev #102

Closed
wants to merge 76 commits into from
Closed

Merge Bakta refactor into Dev #102

wants to merge 76 commits into from

Conversation

kyleoconnell
Copy link
Collaborator

Description

Please Describe the Bug(s) Fixed and/or the Feature(s) Added:

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • [] Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • [] Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • [] Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • [] Did you check for sensitive data, and remove any?
  • [] If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:

ankushkgupta2 and others added 30 commits August 10, 2023 15:36
…annotation, and the output directory are being checked now within general checks
…o concat and correctly format liftoff and repeatmasker gff; added entry subworkflow for the repeatmasker_liftoff strategy and modified workflow and mpxv.nf files
…params log information to a separate module + this module is being called within the main workflow
ankushkgupta2 and others added 27 commits December 10, 2023 23:46
…custom_fields and custom_fields_file for the dynamic metadata fields
@kyleoconnell kyleoconnell self-assigned this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants