Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code migrated to if/else conditionals #6719

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Code migrated to if/else conditionals #6719

merged 1 commit into from
Oct 11, 2023

Conversation

johanna-skylight
Copy link
Contributor

@johanna-skylight johanna-skylight commented Oct 10, 2023 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

Moved the nested ternary operations into a new function that uses if/else conditionals.

Testing

  • All unit testing should pass

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@johanna-skylight johanna-skylight marked this pull request as ready for review October 11, 2023 13:31
BobanL
BobanL approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@johanna-skylight johanna-skylight added this pull request to the merge queue Oct 11, 2023
emyl3
emyl3 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 😸

Merged via the queue into main with commit f9422dc Oct 11, 2023
34 checks passed
@johanna-skylight johanna-skylight deleted the johanna/5598_cleanup_mested_ternary_operators branch October 11, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhao99 fzhao99 fzhao99 approved these changes

@emyl3 emyl3 emyl3 approved these changes

@BobanL BobanL BobanL approved these changes

@mehansen mehansen Awaiting requested review from mehansen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor nested ternary operations
4 participants
@johanna-skylight @BobanL @emyl3 @fzhao99