Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Johanna/5600 replace generic exceptions #6688

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Johanna/5600 replace generic exceptions #6688

merged 3 commits into from
Oct 10, 2023

Conversation

johanna-skylight
Copy link
Contributor

@johanna-skylight johanna-skylight commented Oct 4, 2023 •
edited
Loading

BACKEND PULL REQUEST

Related Issue

Changes Proposed

Create custom exceptions for scenarios where:

  • A user's facility is not being properly initialized during setup of data for the demo env.
  • There is not authentication to be found in the security context when trying to obtain organization roles.

Additional Information

I added some unit testing for the NobodyAuthenticatedException. The other exception needed an extend setup to be tested as it is part of a data setup so I have skipped.

Testing

No regression testing should be affected by these changes.

@johanna-skylight johanna-skylight marked this pull request as ready for review October 4, 2023 20:09
fzhao99
fzhao99 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

BobanL
BobanL approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

emyl3
emyl3 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johanna-skylight johanna-skylight force-pushed the johanna/5600_replace_generic_exceptions branch from 7f6b83b to 95e960a Compare October 10, 2023 14:53
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

42.9% 42.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@johanna-skylight johanna-skylight added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit f314b89 Oct 10, 2023
31 of 32 checks passed
@johanna-skylight johanna-skylight deleted the johanna/5600_replace_generic_exceptions branch October 10, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhao99 fzhao99 fzhao99 approved these changes

@emyl3 emyl3 emyl3 approved these changes

@BobanL BobanL BobanL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace generic exceptions with custom exceptions
4 participants
@johanna-skylight @BobanL @emyl3 @fzhao99