Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MessageTesting API filter errors" #17215

Conversation

victor-chaparro
Copy link
Collaborator

Reverts #17142

@victor-chaparro victor-chaparro requested a review from a team as a code owner January 29, 2025 16:03
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

Test Results

1 272 tests   - 5   1 268 ✅  - 5   7m 35s ⏱️ -8s
  165 suites  - 1       4 💤 ±0 
  165 files    - 1       0 ❌ ±0 

Results for commit e49b834. ± Comparison against base commit 253f770.

This pull request removes 5 tests.
cli.ProcessFhirCommandsTests ‑ applyConditionFilters - with filter errors()
cli.ProcessFhirCommandsTests ‑ applyConditionFilters()
cli.ProcessFhirCommandsTests ‑ evaluateReceiverFilters - with filter errors()
cli.ProcessFhirCommandsTests ‑ evaluateReceiverFilters()
cli.ProcessFhirCommandsTests ‑ handleReceiverFilters()

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

Integration Test Results

 60 files  ±0   60 suites  ±0   43m 56s ⏱️ +54s
428 tests ±0  418 ✅ ±0  10 💤 ±0  0 ❌ ±0 
431 runs  ±0  421 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit e49b834. ± Comparison against base commit 253f770.

@victor-chaparro victor-chaparro merged commit f48d719 into main Jan 29, 2025
24 of 25 checks passed
@victor-chaparro victor-chaparro deleted the revert-17142-engagement/lucero/message-testing-api-condition-filter branch January 29, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants