Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust homepage and in-app nav #264

Merged
merged 3 commits into from
Jan 13, 2025
Merged

adjust homepage and in-app nav #264

merged 3 commits into from
Jan 13, 2025

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Jan 13, 2025 •
edited
Loading

PULL REQUEST

Summary

Fixes homepage redirect as discussed in 1/13 planning. To be revisited once auth is more fully implemented

  • Comments out the sign in button on the homepage to reduce confusion / not expose something that doesn't work
  • Adds the FHIR server configuration and query building paths to the gear for everyone.
  • Will merge after Nick's work goes in so the FHIR server path points to a valid page (happy to ping Shanice as well)

Additional Information

Screenshot 2025-01-13 at 12 44 36 PM
Screenshot 2025-01-13 at 12 44 57 PM

Checklist

  • Descriptive Pull Request title
  • Provide necessary context for design reviewers
  • Update documentation

robertandremitchell
robertandremitchell approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fzhao99 fzhao99 changed the title adjust homepage and navigation paths adjust homepage and in-app nav Jan 13, 2025
@fzhao99 fzhao99 marked this pull request as ready for review January 13, 2025 19:00
@fzhao99 fzhao99 merged commit 192a681 into main Jan 13, 2025
11 checks passed
@fzhao99 fzhao99 deleted the bob/change-signin-nav branch January 13, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-goggins m-goggins m-goggins approved these changes

@robertandremitchell robertandremitchell robertandremitchell approved these changes

@nickclyde nickclyde nickclyde approved these changes

@katyasoup katyasoup Awaiting requested review from katyasoup

@bamader bamader Awaiting requested review from bamader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fzhao99 @nickclyde @robertandremitchell @m-goggins