Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the landing page call-to-action above the fold #261

Merged
merged 3 commits into from
Jan 10, 2025
Merged

move the landing page call-to-action above the fold #261

merged 3 commits into from
Jan 10, 2025

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Jan 10, 2025 •
edited
Loading

PULL REQUEST

As it says on the tin, per a convo with Michelle. Writing a ticket was more work than changing it, so went ahead and did it.

Before
Screenshot 2025-01-10 at 11 21 24 AM

After
Screenshot 2025-01-10 at 11 20 53 AM

  • Remove the extra copy about sample data / change the CTA copy as well
Screenshot 2025-01-10 at 11 20 02 AM
  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers

@fzhao99 fzhao99 changed the title move the landing page demo CTA move the landing page call-to-action above the fold Jan 10, 2025
@fzhao99 fzhao99 marked this pull request as ready for review January 10, 2025 16:22
robertandremitchell
robertandremitchell approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fzhao99 fzhao99 merged commit eaf17fd into main Jan 10, 2025
11 checks passed
@fzhao99 fzhao99 deleted the bob/move-demo-cta branch January 10, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertandremitchell robertandremitchell robertandremitchell approved these changes

@katyasoup katyasoup katyasoup approved these changes

@nickclyde nickclyde Awaiting requested review from nickclyde

@m-goggins m-goggins Awaiting requested review from m-goggins

@bamader bamader Awaiting requested review from bamader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fzhao99 @katyasoup @robertandremitchell