Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo workspace depolyment #258

Merged
merged 10 commits into from
Jan 10, 2025
Merged

Demo workspace depolyment #258

merged 10 commits into from
Jan 10, 2025

Conversation

shanice-skylight
Copy link
Collaborator

@shanice-skylight shanice-skylight commented Jan 9, 2025 •
edited
Loading

PULL REQUEST

Summary

  • Modified ecs_workflow.yaml to be dependent on cd.yaml so that the new image can build before a new deployment is triggered
  • Deployed demo environment on ECS
  • Moving forward the Terraform deployment will not be automatic. Developer will have to run Github action named Terraform Plan & Terraform Apply
    -- After PR is merged to main navigate to Actions select the branch which should be main and environment the PR merged is intended for:

Screenshot 2025-01-09 at 10 15 16 PM

Related Issue

Fixes #

Additional Information

Anything else the review team should know?

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Update documentation

@shanice-skylight shanice-skylight self-assigned this Jan 9, 2025
@shanice-skylight shanice-skylight changed the title modified to add demo as a workspace Demo workspace depolyment Jan 9, 2025
nickclyde
nickclyde approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@nickclyde nickclyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@shanice-skylight shanice-skylight merged commit 2c434d3 into main Jan 10, 2025
11 checks passed
@shanice-skylight shanice-skylight deleted the shanice/deploy_demo_ecs branch January 10, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickclyde nickclyde nickclyde approved these changes

@alismx alismx Awaiting requested review from alismx

Assignees

@shanice-skylight shanice-skylight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanice-skylight @nickclyde