Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query building write functionality pt 1 #256

Merged

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Jan 9, 2025

PULL REQUEST

Summary

Part one of the query building effort to slim down the final PR. Changes include

  • We decided to store the JSON in the query_data and conditions_list columns of the query table by condition ID rather than condition name like we had it previously. Updated the fixtures / unit tests / seed file and one place in the frontend UI accordingly
  • Introduce the code to do the query upserts, to be consumed in the upcoming PR
  • Added some UI gating / updating: should be a no-op for now

Related Issue

Part one of #255

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Update documentation

Copy link

linear bot commented Jan 9, 2025

@fzhao99 fzhao99 force-pushed the bob/que-33-build-out-query-building-write-functionality-pt-1 branch from 81782ff to 4beb9f2 Compare January 9, 2025 16:09
@fzhao99 fzhao99 marked this pull request as ready for review January 9, 2025 16:26
Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I'm having some issues running in dev mode, but I'm not sure if end to end is supposed to work. It looks like the edit querying is a little funky, but maybe it is addressed in part 2:

Screen.Recording.2025-01-09.at.3.04.43.PM.mov

@fzhao99
Copy link
Collaborator Author

fzhao99 commented Jan 9, 2025

looks good. I'm having some issues running in dev mode, but I'm not sure if end to end is supposed to work. It looks like the edit querying is a little funky, but maybe it is addressed in part 2:

Screen.Recording.2025-01-09.at.3.04.43.PM.mov

Yeah this part is just setup! Editing coming in part two

@fzhao99 fzhao99 merged commit 369c0e9 into main Jan 9, 2025
11 checks passed
@fzhao99 fzhao99 deleted the bob/que-33-build-out-query-building-write-functionality-pt-1 branch January 9, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants