FHIR Server Configuration

[nickclyde]

PULL REQUEST

Summary

Adds a page at /fhir-servers to add and edit FHIR servers. Based on these designs.

Currently resolves the following tickets:
https://linear.app/skylight-cdc/issue/QUE-98/create-basic-front-end-for-fhir-server-config
https://linear.app/skylight-cdc/issue/QUE-100/add-edit-and-delete-buttons-to-front-end-fhir-server-table
https://linear.app/skylight-cdc/issue/QUE-101/create-fhir-server-front-end-popup-for-create-new
https://linear.app/skylight-cdc/issue/QUE-102/write-a-creditedit-fhir-server-config-function
https://linear.app/skylight-cdc/issue/QUE-103/write-a-deletefhirserver-function-to-remove-a-db-config
https://linear.app/skylight-cdc/issue/QUE-104/finish-migrating-hard-coded-fhir-servers
https://linear.app/skylight-cdc/issue/QUE-113/update-fhirservers-and-fhir-servers

Screenshots:

[katyasoup]

Looking good! Couple design things I noticed (ignore if these are out of scope!)

• the Delete button looks like it should be left-justified per the Figma mockup

• when I click Test Connection and get a success result, the buttons all grow in height; looks like Figma only shows the success response without the Delete button so I'd double check with @mikang on that
• "Save Changes" always results in a "Failed to update the server configuration." error (but maybe that is out of scope?)

[mikang]

Thanks @katyasoup !

• The cancel button should be just a link, not a white button. Figma below:

• Actually, that's a good catch. The Delete button should be there if the user is editing and then testing the connection. Can we keep the Delete button and change the text to "[checkmark] Success!" ? That shortens the text, so the buttons don't grow in height.

[m-goggins]

Would you be able to add the tickets that this PR covers? It looks like a lot of the ones written up in December but it'd be helpful to see what is left before the Connectathon.

[nickclyde]

@katyasoup @mikang Just pushed the design fixes for the stuff you pointed out!

@m-goggins added the list of tickets this addresses so far. I plan on implementing delete functionality next and moving the hardcoded servers into the table after that as discussed at standup!

[robertandremitchell]

looks good in npm run dev! I was able to successfully add and remove a fhir server without issue.

running into this error on npm run build

./src/app/fhir-servers.ts:14:3
Type error: Type '{ id: string; name: string; hostname: string; headers: {}; }' is not assignable to type 'DevFhirServerConfig'.
  Type '{ id: string; name: string; hostname: string; headers: {}; }' is missing the following properties from type 'FhirServerConfig': last_connection_attempt, last_connection_successful

  12 |   process.env.E2E_LOCAL_FHIR_SERVER ?? "http://hapi-fhir-server:8080/fhir";
  13 | export const fhirServers: Record<string, DevFhirServerConfig> = {
> 14 |   "HELIOS Meld: Direct": {
     |   ^
  15 |     id: "HELIOS Meld: Direct",
  16 |     name: "HELIOS Meld: Direct",
  17 |     hostname: "https://gw.interop.community/HeliosConnectathonSa/open",

[fzhao99]

this lgtm! think the build error is a pretty simple fix, so approving.

Wondering if we should have a followup that adds our hardcoded default servers to the dump file? Might be good to have them available out of the box like we do the default queries.

[m-goggins]

Looks good to me as long as we update the table to pull the list of available FHIR servers from the table and the hard coded list like we do for the drop down or update the table to include all of the hard coded servers (even is just for the connectathon). Left a few other comments for consideration but nothing that should be blocking.

[nickclyde]

Just fixed the build by moving all the hardcoded servers into the database via migration. Also cleaned up the FhirServers constant references. Also had to make the import of Modal a dynamic import to make the build work. Still have a few comments to address but I think this now covers almost all of the FHIR server configuration tickets in Linear!

[robertandremitchell]

Looks good! a few formatting touch-ups, but I think they would be fine to tackle in a follow-up ticket if we want to get the bulk of this merged.

Screen.Recording.2025-01-13.at.8.23.09.AM.mov

[nickclyde]

Good catch @robertandremitchell! Fixed those issues!