new content for query building empty state #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhao99
force-pushed
the
bob/que-114-update-content-for-query-building
branch
from
0c5e8a9 to
453e0e0
Compare
fzhao99
force-pushed
the
bob/que-114-update-content-for-query-building
branch
from
e3c3963 to
9652639
Compare
fzhao99
requested review from
nickclyde,
katyasoup,
bamader,
m-goggins and
robertandremitchell
robertandremitchell
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
looks good. one funky thing: after building the page, I'm not sure if the redirect should function differently, i.e., go to the My Queries page? When you click the back button, it takes you back to the build until you refresh the page.
It's not the biggest deal since the build is a one-time thing for users, just something that seemed a bit off.
Screen.Recording.2025-01-07.at.9.41.40.AM.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Fixes #213 updating the empty state for query building
Additional Information
For the devs, added a snapshot test in the query building empty state to start seeding more frontend functional testing
Redirect with full DB
Screen.Recording.2025-01-06.at.10.01.36.AM.mov
Redirect with empty DB
Screen.Recording.2025-01-06.at.9.59.39.AM.mov
For design
Make sure empty state matches design. If you want to pull it up locally, will need to clear your db first by
docker imagesand take note of the image ID attached to postgres (311abe301881 in the below example)docker compose down --volumes --remove-orphansand thendocker image rm <IMAGE-ID from part 1>/queryBuildingHere's a screenshot in case that's easier:
Checklist