-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup routing and empty state query building pages #107
setup routing and empty state query building pages #107
Conversation
…ect to /query from signin page button click
…uery-connector into kcd/77-login-page
0da0b2f
to
572e256
Compare
f51b7a8
to
ed70798
Compare
query-connector/src/app/query/components/customizeQuery/customizeQueryUtils.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! just to note, for docker, when I tried to follow the logic to sign-in, my little dropdown only had the sign out; I could only get the My queries
button on npm run dev
so we might need another way for @mikang to test since that workflow uses Docker. Or commenting out !isProduction until we merge so that docker can be used to test the workflow.
Ahh yes good point! Realized the docker setups gauge those production flags differently. The page is accessible via URL at /queryBuilding so we can do that too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! nice work on the cleanup bits, too 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 . Couple comments below but nothing is blocking.
PULL REQUEST
Summary
First piece of the query building frontend work that sets up the empty state page and routing. Turning off the navigational link in production, but accessible locally via the gear icon once signed in / in demo. Can also navigate to the empty state page at
/queryBuilding
For design:
Once you navigate to the query building page, do a generic sweep to make sure the empty state page matches designs - spacing / sizing / color of the empty state box pages
Did also tokenize the font styles for h1/h2's (to Merriweather), body (to Public Sans Web), and the site title / mono (to Consolas), so do a step-through of the pages in the rest of the app to ensure those fonts are applied correctly.
Related Issue
Fixes #74 and #73
Additional Information
SelectQuery.tsx
file out of the rootquery
directorystepIndicator
folder into the `components directoryChecklist