Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup routing and empty state query building pages #107

Merged
merged 43 commits into from
Nov 4, 2024

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Oct 31, 2024

PULL REQUEST

Summary

First piece of the query building frontend work that sets up the empty state page and routing. Turning off the navigational link in production, but accessible locally via the gear icon once signed in / in demo. Can also navigate to the empty state page at /queryBuilding

For design:

Once you navigate to the query building page, do a generic sweep to make sure the empty state page matches designs - spacing / sizing / color of the empty state box pages

Did also tokenize the font styles for h1/h2's (to Merriweather), body (to Public Sans Web), and the site title / mono (to Consolas), so do a step-through of the pages in the rest of the app to ensure those fonts are applied correctly.

Related Issue

Fixes #74 and #73

Additional Information

  • Tokenized the fonts of the header files to use the new text styles that we're using across the application using the USWDS stylings. Updated heading, body, site title to match
  • Tokenized some colors for use in a few places with the changes to the spacing
  • Moved the SelectQuery.tsx file out of the root query directory
  • Moved the stepIndicator folder into the `components directory
  • Collapsed two utils files into one
  • Deleted some unnecessary stylings

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Update documentation

Copy link

linear bot commented Oct 31, 2024

@fzhao99 fzhao99 force-pushed the bob/que-30-set-up-routing-to-get-to-query-building branch from 0da0b2f to 572e256 Compare October 31, 2024 22:31
@fzhao99 fzhao99 changed the base branch from main to kcd/77-login-page October 31, 2024 22:39
@fzhao99 fzhao99 force-pushed the bob/que-30-set-up-routing-to-get-to-query-building branch from f51b7a8 to ed70798 Compare October 31, 2024 22:41
@fzhao99 fzhao99 marked this pull request as ready for review November 1, 2024 13:31
@fzhao99 fzhao99 mentioned this pull request Nov 1, 2024
1 task
Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just to note, for docker, when I tried to follow the logic to sign-in, my little dropdown only had the sign out; I could only get the My queries button on npm run dev so we might need another way for @mikang to test since that workflow uses Docker. Or commenting out !isProduction until we merge so that docker can be used to test the workflow.

@fzhao99
Copy link
Collaborator Author

fzhao99 commented Nov 1, 2024

I could only get the My queries button on npm run dev so we might need another way for @mikang to test since that workflow uses Docker.

Ahh yes good point! Realized the docker setups gauge those production flags differently.

The page is accessible via URL at /queryBuilding so we can do that too.

@CDCgov CDCgov deleted a comment from mikang Nov 1, 2024
Copy link
Collaborator

@katyasoup katyasoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! nice work on the cleanup bits, too 😃

Base automatically changed from kcd/77-login-page to main November 1, 2024 20:08
Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 . Couple comments below but nothing is blocking.

query-connector/src/app/layout.tsx Show resolved Hide resolved
query-connector/src/app/page.tsx Show resolved Hide resolved
@fzhao99 fzhao99 merged commit d8fabbf into main Nov 4, 2024
5 checks passed
@fzhao99 fzhao99 deleted the bob/que-30-set-up-routing-to-get-to-query-building branch November 4, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement empty customize query page state
5 participants