Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[map-refactors] Various map ts refactors #1830

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

adamdoe
Copy link
Collaborator

@adamdoe adamdoe commented Jan 10, 2025

[Map Refactors]

  • In generateRuntimeLegend the result property is an array and we're adding other proprerties like description, fromHash, etc on later in the function. This converts result to an object and updates the necessary files used by result.
  • Removes an unnecessary piece of code where values = values
  • Deletes displayGeoName in favor of the helper function

Testing Steps

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@adamdoe adamdoe requested review from joshlacey, Matt-DiPaolo, Mgetz10 and Atash3000 and removed request for joshlacey, Matt-DiPaolo and Mgetz10 January 10, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant