Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-9989] update modals #1827

Merged
merged 2 commits into from
Jan 13, 2025
Merged

[DEV-9989] update modals #1827

merged 2 commits into from
Jan 13, 2025

Conversation

adamdoe
Copy link
Collaborator

@adamdoe adamdoe commented Jan 9, 2025

DEV-9989

On maps, when the modal is too large the modal was cutoff by the overflow CSS property and then extended above the top fold of the screen. This keeps the modal in view and allows vertical scrolling.

Testing Steps

  • Run yarn storybook
  • Open (link)[http://localhost:6006/?path=/story/components-templates-map--map-modal]
  • Verify the modal is centered on desktop viewports
  • Verify the modal doesn't extend above the top of the screen on mobile viewports

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@adamdoe adamdoe requested review from jayb, Mgetz10 and Atash3000 January 10, 2025 17:38
@adamdoe adamdoe marked this pull request as draft January 10, 2025 17:39
@adamdoe adamdoe marked this pull request as ready for review January 10, 2025 17:43
@adamdoe adamdoe merged commit 7bf65c8 into dev Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants