Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:[DEV-2183] Charts Bottom Legend - Reverse Labels not working #1824

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

Atash3000
Copy link
Collaborator

[Replace With Ticket Number]

Testing Steps

Open Chart
On Legend panel set Legend position to Top or Bottom
Click Single Row legend
Click Reverse Labels
Labels should revers back
2: Fixed Vertical sorting
While legend is not Single row click Vertical Sort checkbox
it should sort legend items accordingly even if legend items(names) are updated from data series panel
see attcached images
Screenshot 2025-01-09 at 11 42 59
Screenshot 2025-01-09 at 11 43 17

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@Atash3000 Atash3000 added this to the 4.25.1 milestone Jan 9, 2025
@Atash3000 Atash3000 requested a review from adamdoe January 9, 2025 16:46
Copy link
Collaborator

@adamdoe adamdoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Atash3000 does series renaming still work in legends with that function removed?

@Atash3000 Atash3000 requested a review from adamdoe January 15, 2025 21:44
@Atash3000 Atash3000 merged commit 0ac0961 into dev Jan 15, 2025
@Atash3000 Atash3000 deleted the feature/DEV-2183 branch January 16, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants