Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-10065] Map UX improvements #1819

Merged
merged 3 commits into from
Jan 8, 2025
Merged

[DEV-10065] Map UX improvements #1819

merged 3 commits into from
Jan 8, 2025

Conversation

jayb
Copy link
Collaborator

@jayb jayb commented Jan 8, 2025

[DEV-10065]

Updates a few map issues to the new UX specs:

  • Reduce size of territories label
  • Add padding to annotation box
  • Change "US" to "U.S." and remove colon from labels

Testing Steps

Look at /examples/annotation/usa-map.json locally on this branch vs. dev.

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@jayb jayb requested a review from adamdoe January 8, 2025 15:16
@adamdoe adamdoe merged commit 2d3a9a9 into dev Jan 8, 2025
1 check passed
@adamdoe adamdoe deleted the enhancement/dev-10065-map-fonts branch January 8, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdoe adamdoe adamdoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayb @adamdoe