Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-9325] Custom Map Layers #1706

Merged
merged 13 commits into from
Jan 10, 2025
Merged

[DEV-9325] Custom Map Layers #1706

merged 13 commits into from
Jan 10, 2025

Conversation

adamdoe
Copy link
Collaborator

@adamdoe adamdoe commented Nov 20, 2024

[DEV-9325] Custom Map Layers

This PR starts adding Google Maps API integrations into COVE, with the goal of adding marker clustering on maps.

  • Google Maps

Testing Steps

  • Run yarn storybook
  • Open local link
  • Check that a google map is displaying with the needs api message

Note: this will likely be hidden and needs feedback from BAs/PMs

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

  • Removes ViewportSize in maps type to ViewPort which comes from the core package

@adamdoe adamdoe changed the base branch from main to dev November 20, 2024 20:01
@adamdoe adamdoe added the Hold label Nov 21, 2024
@adamdoe adamdoe added this to the 4.25.1 milestone Nov 26, 2024
@adamdoe adamdoe removed the Hold label Dec 18, 2024
@adamdoe adamdoe marked this pull request as ready for review December 18, 2024 22:48
Copy link
Collaborator

@Mgetz10 Mgetz10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I get this alert but im assuming thats the "needs api message" you mentioned
Screenshot 2025-01-10 at 1 02 55 PM

@adamdoe adamdoe merged commit afea864 into dev Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants