Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 대댓글 수정, 삭제 기능 개선 + 동아리 캐러셀 반응형 추가 #85

Merged
merged 7 commits into from
Mar 3, 2024

Conversation

rbgksqkr
Copy link
Contributor

@rbgksqkr rbgksqkr commented Mar 2, 2024

🚩 관련 이슈
ex) resolve #84

📋 PR Checklist

  • 대댓글 수정, 삭제 기능 개선 (useLongpress 버전업 이슈)
  • Button 컴포넌트 Props랑 이벤트 수정
  • 화면 너비를 계산하여 웹 상에서 보여줄 CircleWebSlider 컴포넌트 분리

📌 유의사항
✅ 테스트 결과
ex) 베이스 브랜치에 포함되기 위한 코드는 모두 정상적으로 동작해야 합니다. 결과물에 대한 스크린샷, GIF, 혹은 라이브

댓글 수정 전 / 댓글 꾹 눌렀을 때 모달창

image image

댓글 수정 중 / 댓글 수정 후 / 댓글 삭제 후

image image image

CircleWebSlider

test.mov

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for caucse ready!

Name Link
🔨 Latest commit 7b8006f
🔍 Latest deploy log https://app.netlify.com/sites/caucse/deploys/65e2beb1250fe60008939d6c
😎 Deploy Preview https://deploy-preview-85--caucse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93
Accessibility: 96
Best Practices: 92
SEO: 92
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for causw-develop ready!

Name Link
🔨 Latest commit 7b8006f
🔍 Latest deploy log https://app.netlify.com/sites/causw-develop/deploys/65e2beb17d0cec0008fef517
😎 Deploy Preview https://deploy-preview-85--causw-develop.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rbgksqkr rbgksqkr requested a review from selfishAltruism March 2, 2024 05:53
Copy link
Contributor

@selfishAltruism selfishAltruism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

믿습니다..

@rbgksqkr rbgksqkr changed the title [FIX] 대댓글 수정, 삭제 기능 개선 [FIX] 대댓글 수정, 삭제 기능 개선 + 동아리 캐러셀 반응형 추가 Mar 2, 2024
@rbgksqkr rbgksqkr self-assigned this Mar 2, 2024
@rbgksqkr rbgksqkr added fix 올바르지 않은 동작, 버그 수정 feat 새로운 기능, 코드 추가 labels Mar 2, 2024
@selfishAltruism selfishAltruism merged commit f1cdb67 into develop Mar 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능, 코드 추가 fix 올바르지 않은 동작, 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants