Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] removed admission number input field #114

Merged
merged 1 commit into from
Mar 24, 2024
Merged

[HOTFIX] removed admission number input field #114

merged 1 commit into from
Mar 24, 2024

Conversation

omjinLTS
Copy link
Contributor

@omjinLTS omjinLTS commented Mar 24, 2024 •
edited
Loading

make admission year with studentId

๐Ÿšฉ ๊ด€๋ จ ์ด์Šˆ
resolve #113

๐Ÿ“‹ PR Checklist

  • ์ž…ํ•™๋…„๋„ input field ์ œ๊ฑฐ
  • admissionYear๋Š” studentId๋กœ ๊ณ„์‚ฐ
    • ํ•™๋ฒˆ ์ž…๋ ฅ์—์„œ ์˜ค๋ฅ˜ ๋ฉ”์„ธ์ง€๊ฐ€ ์ž…ํ•™๋…„๋„๋กœ ๋˜์–ด ์žˆ์–ด ํ•™๋ฒˆ์œผ๋กœ ๋ฐ”๊ฟˆ

๐Ÿ“Œ ์œ ์˜์‚ฌํ•ญ
โœ… ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ
ex) ๋ฒ ์ด์Šค ๋ธŒ๋žœ์น˜์— ํฌํ•จ๋˜๊ธฐ ์œ„ํ•œ ์ฝ”๋“œ๋Š” ๋ชจ๋‘ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค. ๊ฒฐ๊ณผ๋ฌผ์— ๋Œ€ํ•œ ์Šคํฌ๋ฆฐ์ƒท, GIF, ํ˜น์€ ๋ผ์ด๋ธŒ
image

@omjinLTS
hotfix: removed admission number input field
a5198de 
make admission year with studentId
@netlify Netlify
Copy link

netlify bot commented Mar 24, 2024 •
edited
Loading

โœ… Deploy Preview for causw-develop ready!

Name Link
๐Ÿ”จ Latest commit a5198de
๐Ÿ” Latest deploy log https://app.netlify.com/sites/causw-develop/deploys/65ffe50194dcc3000870fdb8
๐Ÿ˜Ž Deploy Preview https://deploy-preview-114--causw-develop.netlify.app
๐Ÿ“ฑ Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 24, 2024 •
edited
Loading

โœ… Deploy Preview for caucse ready!

Name Link
๐Ÿ”จ Latest commit a5198de
๐Ÿ” Latest deploy log https://app.netlify.com/sites/caucse/deploys/65ffe50118f3700008fced58
๐Ÿ˜Ž Deploy Preview https://deploy-preview-114--caucse.netlify.app
๐Ÿ“ฑ Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 83
Accessibility: 84
Best Practices: 92
SEO: 92
PWA: 60
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@selfishAltruism selfishAltruism added the hotfix ๋ฐฐํฌ ๊ด€๋ จ ๊ธด๊ธ‰ํ•œ ์ˆ˜์ • label Mar 24, 2024
selfishAltruism
selfishAltruism approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@selfishAltruism selfishAltruism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omjinLTS omjinLTS merged commit 0f8f2fc into develop Mar 24, 2024
8 checks passed
@omjinLTS omjinLTS deleted the hotfix/#113 branch March 24, 2024 08:36
@lee0jae330
Copy link

Looks good to me

@Ontheway-01
Copy link
Member

good

@selfishAltruism selfishAltruism changed the title hotfix: removed admission number input field [HOTFIX] removed admission number input field Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfishAltruism selfishAltruism selfishAltruism approved these changes

Assignees

@omjinLTS omjinLTS

Labels
hotfix ๋ฐฐํฌ ๊ด€๋ จ ๊ธด๊ธ‰ํ•œ ์ˆ˜์ •
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omjinLTS @lee0jae330 @Ontheway-01 @selfishAltruism