-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix diagnostics; set up CI which includes make run and cargo clippy #5
Draft
zjp-CN
wants to merge
25
commits into
Byte-OS:main
Choose a base branch
from
os-checker:fix-diagnostics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-objcopy --binary-architecture=riscv64 target/riscv64gc-unknown-none-elf/release/kernel --strip-all -O binary target/riscv64gc-unknown-none-elf/release/kernel.bin Could not find tool: objcopy at: /root/.rustup/toolchains/nightly-2023-12-01-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin/llvm-objcopy Consider `rustup component add llvm-tools-preview` make: *** [Makefile:110: build] Error 102
slice_mut_with_len ensures the exact length
slice_mut_with_len ensures the exact length
called `is_none()` after searching an `Iterator` with `find` this is more succinctly expressed by calling `any()` with negation for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some `#[warn(clippy::search_is_some)]` on by default [search_is_some]
package `cargo-platform v0.1.9` cannot be built because it requires rustc 1.78 or newer, while the currently active rustc version is 1.76.0-nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR. I'll make it ready once the following problems are solved.
make BIN=loongarch64-qemu run
leads toqemu-system-loongarch64: command not found
(see CI ), so how to set up for loongarch64?