Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EIP-1559 #448

Draft
wants to merge 35 commits into
base: archive/master
Choose a base branch
from
Draft

Implement EIP-1559 #448

wants to merge 35 commits into from

Conversation

trinhdn2
Copy link

@trinhdn2 trinhdn2 commented Jun 27, 2024 •
edited
Loading

Checklist

  • Define EIP-1559 HF block in chain config and puppeth tool
  • Implement eip1559Signer to handle DynamicFeeTxType, which also implemented the TxData interface
  • Calculate the BaseFee field of header since the fork block
  • Accept and validate DynamicFeeTx in tx pool since the fork block
  • RLP (de)serialize for DynamicFeeTxType
  • Add gasFeeCap and gasTipCap to messages, interfaces, and output of RPC APIs/WS
  • Sort transactions by miner fee (EffectiveGasPrice), which equals total fee - base fee of this block
  • Explain where the base fee amount is burnt in code
  • Gas fee history/oracle?
  • Test VictionZ application
  • Modify Call and Transact method of BoundContracts

trinhdn97 and others added 30 commits June 16, 2023 14:30
@trinhdn97
implements RLP encoding/decoding processing for structs
8253211
@trinhdn97
Update RLP lib
fa67be8
@trinhdn97
Implement RLP encoder code generation tool
9b5dadb
@trinhdn97
Update unit tests and benchmark
ddf35f8
@trinhdn97
Include RLPgen tool to CI
17e4876
@trinhdn97
Add benchmarks for types RLP encoding/decoding
aa7c4b4
@trinhdn97
Generate RLP encoder for some structs
ac89cd3
@trinhdn97
Convert status of receipts from uint to uint64
060f4ce 
Reference: ethereum/go-ethereum#16784
@trinhdn97
Convert status of receipts from uint to uint64
af788c6
@rredmacaw
v2.3.3
f1f9eeb
@trinhdn97
Generalize inner txdata into an interface
22d52cc
@trinhdn97
Strict the current signers to handle LegacyTxType only
a042cae
@trinhdn97
Update transaction format and JSON encoding in RPC API
78190c6
@trinhdn97
Use a shared buffer pool for transaction RLP encoding/decoding
6c2c636
@trinhdn97
Go mod tidy
8552a83
@trinhdn97
Add generic latest signer determinator based on chain config and chainID
fc72f22
@trinhdn97
Receipts supports typed transactions
bf7458a
@trinhdn97
Remove ChainID method from types.Signer interface
f91339b
@trinhdn97
Unify tx encoding in RPC methods
b58dc0d
@trinhdn97
Clean code
f5d3816
@trinhdn97
Define EIP-1559 HF block in chain config and puppeth
d5fcd4d
@trinhdn97
Add some method to inner TxData interface for DynamicFeeTxType
11a35fc 
gasTipCap(), gasFeeCap() and effectiveGasPrice()
@trinhdn97
Implement eip1559Signer to handle DynamicFeeTxType
31b9802
@trinhdn97
Implement DynamicTxType JSON (un)marshalling
e93e095
@trinhdn97
Accept and validate DynamicFeeTx in tx pool
6fde425
@trinhdn97
Fix LatestSigner
64dfb56
@trinhdn97
Merge branch 'update/rlp-lib' into ft/eip_1559
61454d4
@trinhdn97
Add base fee to block/header
b4bcdc4
@trinhdn97
Add gasFeeCap and gasTipCap to messages and interfaces
32419b8
@trinhdn97
[WIP] Miner to include baseFee since EIP1559 fork block
b7ff259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trinhdn2 @trinhdn97 @rredmacaw