[MM-617]: converted the custom post to slack attachment for issue creation event on Github #37

Kshitij-Katiyar · 2024-07-22T10:05:42Z

Summary

Added a slack attachment to the notification whenever a user creates a github issue with Comment, Edit and Close action buttons.
Converting custom post to slack attachment fixes the issues reported in this comment.

…ation

server/plugin/api.go

server/plugin/webhook.go

webapp/src/components/modals/attach_comment_to_issue/attach_comment_to_issue.jsx

webapp/src/components/modals/close_reopen_issue/index.tsx

raghavaggarwal2308

We should also remove the existing custom post file from webapp as that is no longer needed.

server/plugin/api.go

server/plugin/webhook.go

webapp/src/components/modals/attach_comment_to_issue/attach_comment_to_issue.jsx

server/plugin/utils.go

server/plugin/template_test.go

server/plugin/plugin.go

server/plugin/api.go

server/plugin/utils.go

webapp/src/components/modals/close_reopen_issue/index.tsx

server/plugin/api.go

server/plugin/utils.go

Kshitij-Katiyar added 4 commits July 22, 2024 15:30

[MM-617]: converted the custom post to slack attachment for issue cre…

b82c92b

…ation

[MM-617]: fixed lint and testcases

a9dad01

[MM-617]: removed unused variables

016989b

[MM-617]: Fixed the title of the issue slackAttachment

47baa1e

raghavaggarwal2308 requested changes Jul 29, 2024

View reviewed changes

Kshitij-Katiyar added 2 commits July 30, 2024 16:33

[MM-617]: review fixes

421e5a7

[MM-617]: fixed lint

13f3e7e

raghavaggarwal2308 requested changes Jul 30, 2024

View reviewed changes

Kshitij-Katiyar added 2 commits August 1, 2024 13:55

[MM-617]: Review fixes and code clean up

38eeb20

[MM-617]: removed the custom post file

77f9978

Kshitij-Katiyar requested a review from raghavaggarwal2308 August 1, 2024 09:03

raghavaggarwal2308 requested changes Aug 1, 2024

View reviewed changes

server/plugin/plugin.go Outdated Show resolved Hide resolved

raghavaggarwal2308 requested changes Aug 1, 2024

View reviewed changes

server/plugin/api.go Outdated Show resolved Hide resolved

server/plugin/api.go Show resolved Hide resolved

server/plugin/utils.go Show resolved Hide resolved

webapp/src/components/modals/close_reopen_issue/index.tsx Outdated Show resolved Hide resolved

[MM-617]: review fixes

fb6a537

Kshitij-Katiyar requested a review from raghavaggarwal2308 August 1, 2024 11:29

raghavaggarwal2308 requested changes Aug 1, 2024

View reviewed changes

server/plugin/api.go Outdated Show resolved Hide resolved

server/plugin/utils.go Outdated Show resolved Hide resolved

[MM-617]: review fixes

26efdd6

Kshitij-Katiyar requested a review from raghavaggarwal2308 August 1, 2024 12:05

[MM-617]: Fixed lint

ae255f3

raghavaggarwal2308 approved these changes Aug 6, 2024

View reviewed changes

server/plugin/utils.go Outdated Show resolved Hide resolved

[MM-617]: improved the error logging

c2fc3ee

raghavaggarwal2308 merged commit 482fcf9 into MM-618 Aug 6, 2024
4 checks passed

raghavaggarwal2308 deleted the MM-617 branch August 6, 2024 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MM-617]: converted the custom post to slack attachment for issue creation event on Github #37

[MM-617]: converted the custom post to slack attachment for issue creation event on Github #37

Kshitij-Katiyar commented Jul 22, 2024 •

edited

Loading

raghavaggarwal2308 left a comment

[MM-617]: converted the custom post to slack attachment for issue creation event on Github #37

[MM-617]: converted the custom post to slack attachment for issue creation event on Github #37

Conversation

Kshitij-Katiyar commented Jul 22, 2024 • edited Loading

Summary

raghavaggarwal2308 left a comment

Choose a reason for hiding this comment

Kshitij-Katiyar commented Jul 22, 2024 •

edited

Loading