Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have dominion autoload use both names and codes (alt) #908

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

artoonie
Copy link
Collaborator

Alternate approach to #901
Closes #866

Rather than reading the full CVR then cross-checking the CandidateManifest, only use the candidate manifest.

This speeds up autoloading, but has the downside of including (undeclared) as a candidate.

This splits autoloading and undeclared candidate searching into two different steps. Theoretically this should not be a problem: there should be no candidate found in the CVRs that are not found in the candidate manifest.

Let's discuss which approach feels better. I think this is a little cleaner than the other PR.

@artoonie artoonie force-pushed the feature/issue-866_fix-dominion-autoload-alt branch from afa12ec to 80e4677 Compare November 25, 2024 17:46
@artoonie artoonie force-pushed the feature/issue-866_fix-dominion-autoload-alt branch from 80e4677 to a8b94fd Compare November 25, 2024 18:59
@yezr
Copy link
Collaborator

yezr commented Nov 25, 2024

I'm using the dominion_multi_file contest in the test data.

I get every single candidate in the CVRs using this code. Can we use the configured contest id to filter to just the contest we're interested in?

Auto-Loaded with this code
alt-candidate list

Old configured list for the test data
old candidate list

@yezr
Copy link
Collaborator

yezr commented Jan 16, 2025

Added to 3.0 dreams our discussion about reviewing the GatherUnknownCandidateCounts() implementation.

Copy link
Collaborator

@yezr yezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved following 11/14 code review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dominion: auto-load candidate name and alias correctly
2 participants