-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have dominion autoload use both names and codes (alt) #908
Open
artoonie
wants to merge
9
commits into
develop
Choose a base branch
from
feature/issue-866_fix-dominion-autoload-alt
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artoonie
force-pushed
the
feature/issue-866_fix-dominion-autoload-alt
branch
from
November 25, 2024 17:46
afa12ec
to
80e4677
Compare
artoonie
force-pushed
the
feature/issue-866_fix-dominion-autoload-alt
branch
from
November 25, 2024 18:59
80e4677
to
a8b94fd
Compare
yezr
reviewed
Dec 4, 2024
Added to 3.0 dreams our discussion about reviewing the |
yezr
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved following 11/14 code review!
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to #901
Closes #866
Rather than reading the full CVR then cross-checking the CandidateManifest, only use the candidate manifest.
This speeds up autoloading, but has the downside of including
(undeclared)
as a candidate.This splits autoloading and undeclared candidate searching into two different steps. Theoretically this should not be a problem: there should be no candidate found in the CVRs that are not found in the candidate manifest.
Let's discuss which approach feels better. I think this is a little cleaner than the other PR.