Improvements to Inactive Ballot tracking, and corrected reporting of undervotes #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artoonie
force-pushed
the
feature/issue-854_inactive-split
branch
2 times, most recently
from
75341aa to
f293caa
Compare
artoonie
force-pushed
the
feature/issue-854_inactive-split
branch
3 times, most recently
from
08926ab to
57af2fd
Compare
artoonie
commented
Jun 25, 2024
...rcv/test_data/2013_minneapolis_mayor_scale/2013_minneapolis_mayor_scale_expected_summary.csv
Outdated
Show resolved
Hide resolved
yezr
reviewed
Jun 25, 2024
|
I laid out all the open questions in the original issue #854 |
artoonie
force-pushed
the
feature/issue-854_inactive-split
branch
3 times, most recently
from
a26818b to
723b4b8
Compare
artoonie
changed the title
artoonie
force-pushed
the
feature/issue-854_inactive-split
branch
4 times, most recently
from
52cd0cd to
a595e69
Compare
artoonie
force-pushed
the
feature/issue-854_inactive-split
branch
from
a595e69 to
55eee98
Compare
artoonie
changed the title
yezr
reviewed
Jul 11, 2024
...brightspots/rcv/test_data/2013_minneapolis_mayor/2013_minneapolis_mayor_expected_summary.csv
Outdated
Show resolved
Hide resolved
...brightspots/rcv/test_data/2013_minneapolis_mayor/2013_minneapolis_mayor_expected_summary.csv
Show resolved
Hide resolved
|
note for when this is merged that RCVRC needs to document how this changes the description for ballots in the audit log and the totally unranked ballots in the summary.csv 
|
yezr
reviewed
Jul 15, 2024
...brightspots/rcv/test_data/2013_minneapolis_mayor/2013_minneapolis_mayor_expected_summary.csv
Show resolved
Hide resolved
...ghtspots/rcv/test_data/csv_missing_header_test/csv_missing_header_test_expected_summary.json
Show resolved
Hide resolved
...resources/network/brightspots/rcv/test_data/excluded_test/excluded_test_expected_summary.csv
Outdated
Show resolved
Hide resolved
|
@artoonie can we change the undervote description in the |
|
All comments addressed, let me know if there's more needed from RCVRC's side |
yezr
reviewed
Aug 27, 2024
src/main/java/network/brightspots/rcv/CommonDataFormatReader.java
Outdated
Show resolved
Hide resolved
yezr
approved these changes
Sep 3, 2024
* fix some math on the per-slice inactive ballots * add test for residual surplus in by-slice * don't fix the residual surplus by-slice as its never shown * lint * clean up * remove unnecessary comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally designed to handle both #780 and #854. However, #854 has additional questions and has been deferred out of 2.0.
Still, this PR made some improvements that resolved #780 in a nice way, so I'm modifying this PR to just resolve #780 without the "partially ranked" vs "fully ranked" split in #854.
Therefore, this PR has code that is outside of the scope of #780 but makes it easy to accomplish #854 in the future -- things like tracking whether a ballot used all of its known rankings.