Fix for clearballot parsing: ignore quoted text in non-header rows (#881

) * fix clearballot cvr parsing: ignore commas in quoted text in non-header rows * Saving unquoted comma regex in a static variable and incrementing version number to 1.3.1 RC3 --------- Co-authored-by: ryu <[email protected]>
BrightSpots · Sep 6, 2024 · 3baa4b9 · 3baa4b9
1 parent 68d2e19
commit 3baa4b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/main/java/network/brightspots/rcv/ClearBallotCvrReader.java b/src/main/java/network/brightspots/rcv/ClearBallotCvrReader.java
@@ -32,6 +32,8 @@
 
 class ClearBallotCvrReader {
 
+  private static final String unQuotedCommaRegex = ",(?=(?:[^\"]*\"[^\"]*\")*[^\"]*$)";
+
   private final String cvrPath;
   private final ContestConfig contestConfig;
   private final String undeclaredWriteInLabel;
@@ -58,7 +60,7 @@ void readCastVoteRecords(List<CastVoteRecord> castVoteRecords, String contestId)
         Logger.severe("No header row found in cast vote record file: %s", this.cvrPath);
         throw new CvrParseException();
       }
-      String[] headerData = firstRow.split(",(?=(?:[^\"]*\"[^\"]*\")*[^\"]*$)");
+      String[] headerData = firstRow.split(unQuotedCommaRegex);
       if (headerData.length < CvrColumnField.ChoicesBegin.ordinal()) {
         Logger.severe("No choice columns found in cast vote record file: %s", this.cvrPath);
         throw new CvrParseException();
@@ -103,7 +105,7 @@ void readCastVoteRecords(List<CastVoteRecord> castVoteRecords, String contestId)
           break;
         }
         // parse rankings
-        String[] cvrData = row.split(",");
+        String[] cvrData = row.split(unQuotedCommaRegex);
         ArrayList<Pair<Integer, String>> rankings = new ArrayList<>();
         for (var entry : columnIndexToRanking.entrySet()) {
           if (Integer.parseInt(cvrData[entry.getKey()]) == 1) {

diff --git a/src/main/java/network/brightspots/rcv/Main.java b/src/main/java/network/brightspots/rcv/Main.java
@@ -27,7 +27,7 @@
 public class Main extends GuiApplication {
 
   public static final String APP_NAME = "RCTab";
-  public static final String APP_VERSION = "1.3.1 RC2";
+  public static final String APP_VERSION = "1.3.1 RC3";
 
   /**
    * Main entry point to RCTab.