Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BetterBags category function #46

Closed
wants to merge 3 commits into from

Conversation

guicaulada
Copy link

@guicaulada guicaulada commented Apr 1, 2024

Register a category function on the AdiBags successor addon BetterBags.

The category function will create a custom category for each item set and correctly alocate the items on the right category.

Screenshots:
image
image
image

@Breeni
Copy link
Owner

Breeni commented Apr 15, 2024

How does this compare to how BetterBags handles the built in equipment sets? Does renaming sets, adding/removing items, and such keep the BetterBags categories up to date?

@guicaulada
Copy link
Author

Changes to gear sets from BetterBags are only reflected upon a reload or a re-sort of the bag by right clicking the bag icon on the top left.

With the current implementation BtWLoadouts is only adding the items to the custom category upon load, so a reload would be necessary to update the sets.

For default equipment sets I know we can tie into EQUIPMENT_SETS_CHANGED but I'm not sure BtWLoadouts fire any events for equipment sets updates within the addon.

@Breeni
Copy link
Owner

Breeni commented Apr 22, 2024

I'm going to extend the internal event system so things can be triggered from changing the sets. There will still probably be issues with items that are in multiple sets possibly not being updated correctly sometimes. It'd also be nice if BetterBags allowed for categories on specific items instead of item ids but that would probably require a more dramatic change on their end

@guicaulada guicaulada closed this Aug 15, 2024
@guicaulada guicaulada deleted the betterbags-categories branch August 15, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants